From ff6a92363a0df72ea749a71d9a5b235e8faea914 Mon Sep 17 00:00:00 2001 From: toggm Date: Wed, 17 Apr 2019 09:54:03 +0200 Subject: [PATCH 1/2] bumped android sdk --- android/build.gradle | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 1f28a4d..ec102a7 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -13,12 +13,12 @@ buildscript { apply plugin: 'com.android.library' android { - compileSdkVersion 26 - buildToolsVersion "26.0.1" + compileSdkVersion 28 + buildToolsVersion "28.0.3" defaultConfig { minSdkVersion 16 - targetSdkVersion 26 + targetSdkVersion 28 versionCode 1 versionName "1.0" } @@ -35,4 +35,3 @@ repositories { dependencies { compile 'com.facebook.react:react-native:+' } - \ No newline at end of file From a443ddee3446a96656730f925d818376a7594a0d Mon Sep 17 00:00:00 2001 From: toggm Date: Wed, 17 Apr 2019 21:24:59 +0200 Subject: [PATCH 2/2] made android sdk configurable --- android/build.gradle | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index ec102a7..4110ece 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -12,13 +12,17 @@ buildscript { apply plugin: 'com.android.library' +def safeExtGet(prop, fallback) { + rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback +} + android { - compileSdkVersion 28 - buildToolsVersion "28.0.3" + compileSdkVersion safeExtGet('compileSdkVersion', 28) + buildToolsVersion safeExtGet('buildToolsVersion', "28.0.3") defaultConfig { - minSdkVersion 16 - targetSdkVersion 28 + minSdkVersion safeExtGet('minSdkVersion', 16) + targetSdkVersion safeExtGet('targetSdkVersion', 28) versionCode 1 versionName "1.0" }