Improve count on list with greater/smaller-than #4507
Draft
+153
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Oct 31, 2025
staabm
force-pushed
the
great
branch
4 times, most recently
from
ca2ffe9 to
fc8643e
Compare
staabm
commented
Dec 6, 2025
Comment on lines
+1195
to
+1215
| $intersection = []; | ||
| $intersection[] = $arrayType; | ||
| $intersection[] = new NonEmptyArrayType(); | ||
|
|
||
| $zero = new ConstantIntegerType(0); | ||
| $i = 0; | ||
| foreach ($builderData as [$offsetType, $valueType]) { | ||
| // non-empty-list already implies the offset 0 | ||
| if ($zero->isSuperTypeOf($offsetType)->yes()) { | ||
| continue; | ||
| } | ||
|
|
||
| if ($i > self::MAX_ACCESSORIES_LIMIT) { | ||
| break; | ||
| } | ||
|
|
||
| $intersection[] = new HasOffsetValueType($offsetType, $valueType); | ||
| $i++; | ||
| } | ||
|
|
||
| $resultTypes[] = TypeCombinator::intersect(...$intersection); |
Contributor
Author
There was a problem hiding this comment.
could also use a AccessoryArraySize, but this likely would be more involved and require a bigger refactor.
therefore I went with this simple approach which covers most useful use-cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13747
fixes ~55x "offset might not exist" errors on phpstan-src with
reportPossiblyNonexistentGeneralArrayOffset: true