adding phpstan-phpunit and make Tests folder to respect phpstan level 2 (#21)

Author: mihaileu

Tests/RabbitMq/AMQPConnectionFactoryTest.php

@@ -6,6 +6,7 @@
 use OldSound\RabbitMqBundle\RabbitMq\AMQPConnectionFactory;
 use OldSound\RabbitMqBundle\Tests\RabbitMq\Fixtures\AMQPConnection;
 use OldSound\RabbitMqBundle\Tests\RabbitMq\Fixtures\AMQPSocketConnection;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class AMQPConnectionFactoryTest extends TestCase
@@ -335,7 +336,7 @@ public function testConnectionsParametersProvider()
     /**
      * Preparing ConnectionParametersProviderInterface instance
      *
-     * @return \PHPUnit_Framework_MockObject_MockObject|ConnectionParametersProviderInterface
+     * @return MockObject
      */
     private function prepareConnectionParametersProvider()
     {

Tests/RabbitMq/BaseAmqpTest.php

@@ -2,6 +2,7 @@
 
 namespace OldSound\RabbitMqBundle\Tests\RabbitMq;
 
+use PHPUnit\Framework\MockObject\MockObject;
 use Symfony\Contracts\EventDispatcher\EventDispatcherInterface as ContractsEventDispatcherInterface;
 use OldSound\RabbitMqBundle\Event\AMQPEvent;
 use OldSound\RabbitMqBundle\RabbitMq\BaseAmqp;
@@ -45,7 +46,7 @@ public function testNotLazyConnection()
 
     public function testDispatchEvent()
     {
-        /** @var BaseAmqp|\PHPUnit_Framework_MockObject_MockObject $baseAmqpConsumer */
+        /** @var BaseAmqp|MockObject $baseAmqpConsumer */
         $baseAmqpConsumer = $this->getMockBuilder('OldSound\RabbitMqBundle\RabbitMq\BaseAmqp')
             ->disableOriginalConstructor()
             ->getMock();
@@ -76,9 +77,9 @@ public function testDispatchEvent()
     }
 
     /**
-     * @param $name
-     * @param $obj
-     * @param $params
+     * @param string $name
+     * @param MockObject $obj
+     * @param array $params
      *
      * @return mixed
      */

Tests/RabbitMq/BindingTest.php

@@ -4,6 +4,7 @@
 
 use OldSound\RabbitMqBundle\RabbitMq\Binding;
 use PHPUnit\Framework\Assert;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class BindingTest extends TestCase
@@ -15,7 +16,7 @@ protected function getBinding($amqpConnection, $amqpChannel)
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject
+     * @return MockObject
      */
     protected function prepareAMQPConnection()
     {

Tests/RabbitMq/DynamicConsumerTest.php

@@ -2,7 +2,9 @@
 
 namespace OldSound\RabbitMqBundle\Tests\RabbitMq;
 
+use OldSound\RabbitMqBundle\Provider\QueueOptionsProviderInterface;
 use OldSound\RabbitMqBundle\RabbitMq\DynamicConsumer;
+use PHPUnit\Framework\MockObject\MockObject;
 
 class DynamicConsumerTest extends ConsumerTest
 {
@@ -14,7 +16,7 @@ public function getConsumer($amqpConnection, $amqpChannel)
     /**
      * Preparing QueueOptionsProviderInterface instance
      *
-     * @return \PHPUnit_Framework_MockObject_MockObject|QueueOptionsProviderInterface
+     * @return MockObject|QueueOptionsProviderInterface
      */
     private function prepareQueueOptionsProvider()
     {

Tests/RabbitMq/MultipleConsumerTest.php

@@ -9,6 +9,7 @@
 use PhpAmqpLib\Connection\AMQPConnection;
 use PhpAmqpLib\Message\AMQPMessage;
 use PHPUnit\Framework\Assert;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class MultipleConsumerTest extends TestCase
@@ -23,14 +24,14 @@ class MultipleConsumerTest extends TestCase
     /**
      * AMQP channel
      *
-     * @var \PHPUnit_Framework_MockObject_MockObject|AMQPChannel
+     * @var MockObject|AMQPChannel
      */
     private $amqpChannel;
 
     /**
      * AMQP connection
      *
-     * @var \PHPUnit_Framework_MockObject_MockObject|AMQPConnection
+     * @var MockObject|AMQPConnection
      */
     private $amqpConnection;
 
@@ -202,7 +203,7 @@ public function processMessageProvider()
     /**
      * Preparing AMQP Connection
      *
-     * @return \PHPUnit_Framework_MockObject_MockObject|AMQPConnection
+     * @return MockObject|AMQPConnection
      */
     private function prepareAMQPConnection()
     {
@@ -214,7 +215,7 @@ private function prepareAMQPConnection()
     /**
      * Preparing AMQP Connection
      *
-     * @return \PHPUnit_Framework_MockObject_MockObject|AMQPChannel
+     * @return MockObject|AMQPChannel
      */
     private function prepareAMQPChannel()
     {
@@ -226,7 +227,7 @@ private function prepareAMQPChannel()
     /**
      * Preparing QueuesProviderInterface instance
      *
-     * @return \PHPUnit_Framework_MockObject_MockObject|QueuesProviderInterface
+     * @return MockObject|QueuesProviderInterface
      */
     private function prepareQueuesProvider()
     {
@@ -237,8 +238,8 @@ private function prepareQueuesProvider()
     /**
      * Preparing AMQP Channel Expectations
      *
-     * @param $expectedMethod
-     * @param $expectedRequeue
+     * @param mixed $expectedMethod
+     * @param string $expectedRequeue
      *
      * @return void
      */
@@ -261,7 +262,7 @@ private function prepareAMQPChannelExpectations($expectedMethod, $expectedRequeu
     /**
      * Prepare callback
      *
-     * @param $processFlag
+     * @param bool $processFlag
      * @return callable
      */
     private function prepareCallback($processFlag)

composer.json

@@ -16,7 +16,8 @@
         "symfony/yaml":                 "^4.3|^5.0",
         "symfony/console":              "^4.3|^5.0",
         "php-amqplib/php-amqplib":      "^2.6",
-        "psr/log":                      "^1.0"
+        "psr/log":                      "^1.0",
+        "phpstan/phpstan-phpunit": "^0.12.6"
     },
     "require-dev": {
         "symfony/serializer":           "^4.3|^5.0",

phpstan.neon.dist

@@ -1,3 +1,6 @@
+includes:
+	- vendor/phpstan/phpstan-phpunit/extension.neon
+	- vendor/phpstan/phpstan-phpunit/rules.neon
 parameters:
     level: 1
     paths: