Modified fabric command, completed unit test

Author: fatmuemoo

Command/SetupFabricCommand.php

@@ -28,8 +28,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $partsHolder = $this->getContainer()->get('old_sound_rabbit_mq.parts_holder');
 
-        foreach ($partsHolder->getParts('old_sound_rabbit_mq.base_amqp') as $baseAmqp) {
-            $baseAmqp->setupFabric();
+        foreach (array('base_amqp', 'binding') as $key) {
+            foreach ($partsHolder->getParts('old_sound_rabbit_mq.' . $key) as $baseAmqp) {
+                $baseAmqp->setupFabric();
+            }
         }
+
     }
 }

DependencyInjection/OldSoundRabbitMqExtension.php

@@ -106,11 +106,12 @@ protected function loadBindings()
             ksort($binding);
             $definition = new Definition($binding['class']);
             $definition->addTag('old_sound_rabbit_mq.binding');
-            $definition->addMethodCall('setExchange', array($binding['exchange']));
+            $definition->addMethodCall('setArguments', array($binding['arguments']));
             $definition->addMethodCall('setDestination', array($binding['destination']));
-            $definition->addMethodCall('setRoutingKey', array($binding['routing_key']));
-            $definition->addMethodCall('isNowait', array($binding['nowait']));
             $definition->addMethodCall('setDestinationIsExchange', array($binding['destination_is_exchange']));
+            $definition->addMethodCall('setExchange', array($binding['exchange']));
+            $definition->addMethodCall('isNowait', array($binding['nowait']));
+            $definition->addMethodCall('setRoutingKey', array($binding['routing_key']));
             $this->injectConnection($definition, $binding['connection']);
             $key = md5(json_encode($binding));
             if ($this->collectorEnabled) {

Tests/DependencyInjection/OldSoundRabbitMqExtensionTest.php

@@ -3,6 +3,7 @@
 namespace OldSound\RabbitMqBundle\Tests\DependencyInjection;
 
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
@@ -130,6 +131,9 @@ public function testFooBinding()
         $key = md5(json_encode($binding));
         $name = sprintf('old_sound_rabbit_mq.%s_binding', $key);
         $this->assertTrue($container->has($name));
+        $definition = $container->getDefinition($name);
+        $this->assertEquals((string) $definition->getArgument(0), 'old_sound_rabbit_mq.connection.default');
+        $this->assertBindingMethodCalls($definition, $binding);
     }
 
     public function testMooBinding()
@@ -149,8 +153,54 @@ public function testMooBinding()
         $key = md5(json_encode($binding));
         $name = sprintf('old_sound_rabbit_mq.%s_binding', $key);
         $this->assertTrue($container->has($name));
+        $definition = $container->getDefinition($name);
+        $this->assertEquals((string) $definition->getArgument(0), 'old_sound_rabbit_mq.connection.default2');
+        $this->assertBindingMethodCalls($definition, $binding);
     }
 
+    protected function assertBindingMethodCalls(Definition $definition, $binding)
+    {
+        $this->assertEquals(array(
+            array(
+                'setArguments',
+                array(
+                    $binding['arguments']
+                )
+            ),
+            array(
+                'setDestination',
+                array(
+                    $binding['destination']
+                )
+            ),
+            array(
+                'setDestinationIsExchange',
+                array(
+                    $binding['destination_is_exchange']
+                )
+            ),
+            array(
+                'setExchange',
+                array(
+                    $binding['exchange']
+                )
+            ),
+            array(
+                'isNowait',
+                array(
+                    $binding['nowait']
+                )
+            ),
+            array(
+                'setRoutingKey',
+                array(
+                    $binding['routing_key']
+                )
+            ),
+        ),
+            $definition->getMethodCalls()
+        );
+    }
     public function testFooProducerDefinition()
     {
         $container = $this->getContainer('test.yml');