Commit af10272
committed
Fixes #123
### Summary
Adds an e2e test to reproduce the async function compilation hang reported in issue #123. However, **the issue cannot be reproduced** in the current codebase - compilation with async function handlers co
mpletes successfully.
### Issue Description
@cpursley reported that compilation would hang when using async functions in flow step handlers. After removing the `async` keywords, compilation worked. The problematic pattern was:
```typescript
.step(
{ slug: 'process_company_logo' },
async (input) => await processCompanyLogoTask({ ... })
)
```
### Changes Made
- **Test Flow**: Added `pkgs/cli/examples/async-function-hang.ts` - reproduces the exact pattern from the issue with dummy async tasks
- **E2E Test Script**: Added `pkgs/cli/scripts/test-async-hang-issue-123` - automated test with 30s timeout to detect hangs
- **Nx Target**: Added `test:e2e:async-hang-issue-123` to `pkgs/cli/project.json`
### Test Results
The test passes successfully, indicating:
1. Async functions in handlers compile without hanging
2. The compilation completes in under 30 seconds
3. Migration files are generated correctly
### Possible Explanations
The issue may have been:
- Fixed by other changes in the codebase
- Specific to the user's environment or the actual task imports used
- Related to network issues when Deno was fetching dependencies
The test now provides regression protection if this issue resurfaces.
1 parent 706462d commit af10272
File tree
3 files changed
+115
-1
lines changed- pkgs/cli
- examples
- scripts
3 files changed
+115
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
80 | 90 | | |
81 | 91 | | |
82 | 92 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
0 commit comments