diff --git a/CHANGES.txt b/CHANGES.txt index 91c66db..e6be9a4 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1 +1,2 @@ -v0.1.0, 20 February 2014 -- Initial release. \ No newline at end of file +v0.1.0, 20 February 2014 -- Initial release. +v0.1.1, 18 July 2014 -- Parameter Update. diff --git a/MANIFEST b/MANIFEST index 9b0f45d..5e44865 100644 --- a/MANIFEST +++ b/MANIFEST @@ -1,6 +1,5 @@ # file GENERATED by distutils, do NOT edit -CHANGES.txt -README.txt +README.md setup.py payzippysdk/ChargingRequest.py payzippysdk/ChargingResponse.py diff --git a/MANIFEST.in b/MANIFEST.in new file mode 100644 index 0000000..efa752e --- /dev/null +++ b/MANIFEST.in @@ -0,0 +1 @@ +include *.md diff --git a/dist/PayZippySDK-0.1.1.tar.gz b/dist/PayZippySDK-0.1.1.tar.gz new file mode 100644 index 0000000..d968caa Binary files /dev/null and b/dist/PayZippySDK-0.1.1.tar.gz differ diff --git a/payzippysdk/ChargingRequest.py b/payzippysdk/ChargingRequest.py index f98d7fd..454331f 100644 --- a/payzippysdk/ChargingRequest.py +++ b/payzippysdk/ChargingRequest.py @@ -62,6 +62,16 @@ def set_merchant_transaction_id(self, merchant_transaction_id): def set_transaction_amount(self, transaction_amount): self.request_params[Constants.TRANSACTION_AMOUNT] = transaction_amount + def set_buyer_phone_no(self, buyer_phone_no): + self.request_params[Constants.BUYER_PHONE_NO] = buyer_phone_no + + def set_item_total(self, item_total): + self.request_params[Constants.ITEM_TOTAL] = item_total + + def set_item_vertical(self, item_vertical): + self.request_params[Constants.ITEM_VERTICAL] = item_vertical + + # =============================================== # Optional parameters related to merchant details # =============================================== @@ -88,9 +98,6 @@ def set_udf5(self, udf5): # Optional parameters related to buyer details # ============================================ - def set_buyer_phone_no(self, buyer_phone_no): - self.request_params[Constants.BUYER_PHONE_NO] = buyer_phone_no - def set_buyer_unique_id(self, buyer_unique_id): self.request_params[Constants.BUYER_UNIQUE_ID] = buyer_unique_id @@ -160,12 +167,6 @@ def set_address_count(self, address_count): def set_sales_channel(self, sales_channel): self.request_params[Constants.SALES_CHANNEL] = sales_channel - def set_item_total(self, item_total): - self.request_params[Constants.ITEM_TOTAL] = item_total - - def set_item_vertical(self, item_vertical): - self.request_params[Constants.ITEM_VERTICAL] = item_vertical - def set_sms_notify_number(self, sms_notify_number): self.request_params[Constants.SMS_NOTIFY_NUMBER] = sms_notify_number diff --git a/payzippysdk/ValidityCheck.py b/payzippysdk/ValidityCheck.py index 679a962..16d9e5d 100644 --- a/payzippysdk/ValidityCheck.py +++ b/payzippysdk/ValidityCheck.py @@ -81,6 +81,16 @@ def validate_charge_params(params): params.get(Constants.HASH_METHOD).upper() in Constants.HASH_METHOD_REQUIREMENTS): raise ValueError(Constants.HASH_METHOD_INVALID) + elif not(params.get(Constants.BUYER_PHONE_NO)) or len( + params.get(Constants.BUYER_PHONE_NO)) > Constants.BUYER_PHONE_NO_MAXLEN: + raise ValueError(Constants.BUYER_PHONE_NO_INVALID) + elif not(params.get(Constants.ITEM_TOTAL)) or len( + params.get(Constants.ITEM_TOTAL)) > Constants.ITEM_TOTAL_MAXLEN: + raise ValueError(Constants.ITEM_TOTAL_INVALID) + elif not(params.get(Constants.ITEM_VERTICAL)) or len( + params.get(Constants.ITEM_VERTICAL)) > Constants.ITEM_VERTICAL_MAXLEN: + raise ValueError(Constants.ITEM_VERTICAL_INVALID) + # ''' # Check for payment method specific parameters # ''' @@ -123,10 +133,6 @@ def validate_charge_params(params): raise ValueError(Constants.EXPIRY_YEAR_INVALID) # Check for other parameters which enforce max length constraint - elif Constants.BUYER_PHONE_NO in param_keys and len( - params.get(Constants.BUYER_PHONE_NO)) > Constants.BUYER_PHONE_NO_MAXLEN: - raise ValueError(Constants.BUYER_PHONE_NO_INVALID) - elif Constants.BUYER_UNIQUE_ID in param_keys and len( params.get(Constants.BUYER_UNIQUE_ID)) > Constants.BUYER_UNIQUE_ID_MAXLEN: raise ValueError(Constants.BUYER_UNIQUE_ID_INVALID) diff --git a/setup.py b/setup.py index 604f48b..4dfed39 100644 --- a/setup.py +++ b/setup.py @@ -2,7 +2,7 @@ setup( name='PayZippySDK', - version='0.1.0', + version='0.1.1', author='PayZippy', author_email='merchant.care@payzippy.com', packages=['payzippysdk'],