Merge pull request #239 from ParsePlatform/richardross.offlinestore.children.fix

Fixed an issue where LDS wouldn't search the whole subtree for objects not yet fetched.

Author: richardjrossiii

Parse/Internal/PFEventuallyPin.m

@@ -158,7 +158,14 @@ + (BFTask *)_pinEventually:(PFObject *)object
         pin[PFEventuallyPinKeyCommand] = commandDictionary;
     }
 
-    return [[pin pinInBackgroundWithName:PFEventuallyPinPinName] continueWithBlock:^id(BFTask *task) {
+    // NOTE: This is needed otherwise ARC releases the pins before we have a chance to persist the new ones to disk,
+    // Which means we'd lose any columns on objects in eventually pins not currently in memory.
+    __block NSArray *existingPins = nil;
+    return [[[self findAllEventuallyPin] continueWithSuccessBlock:^id(BFTask *task) {
+        existingPins = task.result;
+        return [pin pinInBackgroundWithName:PFEventuallyPinPinName];
+    }] continueWithSuccessBlock:^id(BFTask *task) {
+        existingPins = nil;
         return pin;
     }];
 }