Skip to content

Commit d9e63be

Browse files
committed
nits: TODOs
1 parent 521d559 commit d9e63be

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Parse/Parse/Internal/LocalDataStore/OfflineQueryLogic/PFOfflineQueryLogic.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ - (id)valueForContainer:(id)container
121121
// anything like ParseObjects and arrays.
122122
if (!(value == nil || [value isKindOfClass:[NSDictionary class]])) {
123123
if (depth > 0) {
124-
// TODO: flovilmart is it safe?
124+
// TODO (flovilmart): is it safe to swallow the error here?
125125
id restFormat = [[PFPointerObjectEncoder objectEncoder] encodeObject:value error:nil];
126126
if ([restFormat isKindOfClass:[NSDictionary class]]) {
127127
return [self valueForContainer:restFormat key:rest depth:depth + 1];

Parse/Parse/Internal/Object/Coder/File/PFObjectFileCoder.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ @implementation PFObjectFileCoder
2323
+ (NSData *)dataFromObject:(PFObject *)object usingEncoder:(PFEncoder *)encoder {
2424
NSMutableDictionary *result = [NSMutableDictionary dictionary];
2525
result[@"classname"] = object._state.parseClassName;
26-
// TODO: @flovilmart verify if it's safe
26+
// TODO (flovilmart): is it safe to swallow error here?
2727
result[@"data"] = [object._state dictionaryRepresentationWithObjectEncoder:encoder error:nil];
2828
return [PFJSONSerialization dataFromJSONObject:result];
2929
}

Parse/Parse/Internal/Query/Controller/PFCachedQueryController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ - (BFTask *)_runNetworkCommandAsync:(PFRESTCommand *)command
153153
///--------------------------------------
154154

155155
- (NSString *)cacheKeyForQueryState:(PFQueryState *)queryState sessionToken:(NSString *)sessionToken {
156-
// TODO: @flovimart verify if safe
156+
// TODO (flovilmart): verify if safe to swallow error here
157157
return [PFRESTQueryCommand findCommandForQueryState:queryState withSessionToken:sessionToken error:nil].cacheKey;
158158
}
159159

0 commit comments

Comments
 (0)