Merge pull request #732 from ParsePlatform/nlutsenko.constants

Cleanup constants in PFConstants.h

Author: nlutsenko

Parse/Internal/Commands/PFRESTCommand.m

@@ -28,6 +28,7 @@
 
 // Increment this when you change the format of cache values.
 static const int PFRESTCommandCacheKeyVersion = 1;
+static const int PFRESTCommandCacheKeyParseAPIVersion = 2;
 
 @implementation PFRESTCommand
 
@@ -86,7 +87,7 @@ - (NSString *)cacheKey {
     _cacheKey = [NSString stringWithFormat:@"PFRESTCommand.%i.%@.%@.%ld.%@",
                  PFRESTCommandCacheKeyVersion, self.httpMethod, PFMD5HashFromString(self.httpPath),
                  // We use MD5 instead of native hash because it collides too much.
-                 (long)PARSE_API_VERSION, PFMD5HashFromString(parametersCacheKey)];
+                 (long)PFRESTCommandCacheKeyParseAPIVersion, PFMD5HashFromString(parametersCacheKey)];
     return _cacheKey;
 }
 

Parse/PFConstants.h

@@ -9,17 +9,12 @@
 
 #import <Foundation/Foundation.h>
 
-@class PFObject;
-@class PFUser;
-
 ///--------------------------------------
-#pragma mark - Version
+#pragma mark - SDK Version
 ///--------------------------------------
 
 #define PARSE_VERSION @"1.11.0"
 
-extern NSInteger const PARSE_API_VERSION;
-
 ///--------------------------------------
 #pragma mark - Platform
 ///--------------------------------------
@@ -123,6 +118,9 @@ typedef NS_ENUM(uint8_t, PFLogLevel) {
 #pragma mark - Errors
 ///--------------------------------------
 
+/**
+ Error domain used for all `NSError`s in the SDK.
+ */
 extern NSString *const _Nonnull PFParseErrorDomain;
 
 /**
@@ -359,6 +357,9 @@ typedef NS_ENUM(NSInteger, PFErrorCode) {
 #pragma mark - Blocks
 ///--------------------------------------
 
+@class PFObject;
+@class PFUser;
+
 typedef void (^PFBooleanResultBlock)(BOOL succeeded, NSError *_Nullable error);
 typedef void (^PFIntegerResultBlock)(int number, NSError *_Nullable error);
 typedef void (^PFArrayResultBlock)(NSArray *_Nullable objects, NSError *_Nullable error);

Parse/PFConstants.m

@@ -9,8 +9,6 @@
 
 #import "PFConstants.h"
 
-NSInteger const PARSE_API_VERSION          = 2;
-
 #if TARGET_OS_IOS
 NSString *const kPFDeviceType = @"ios";
 #elif PF_TARGET_OS_OSX