Send correct HTTP status codes for each user endpoint

Author: pH-7

src/Service/User.php

@@ -31,13 +31,16 @@ public function create(mixed $data): array|object
 
 
             if (UserDal::create($userEntity) === false) {
-                // Set an internal error when we cannot add an entry to the database
+                // Set an internal error 500 when we cannot add an entry to the database
                 Http::setHeadersByCode(StatusCode::INTERNAL_SERVER_ERROR);
 
                 // Set to empty result, because an issue happened. The client has to handle this properly
                 $data = [];
             }
 
+            // Send a 201 when the user has been successfully added to DB
+            Http::setHeadersByCode(StatusCode::CREATED);
+
             return $data; // return statement exists the function and doesn't go beyond this scope
         }
 
@@ -64,6 +67,9 @@ public function update(mixed $postBody): array|object
             }
 
             if (UserDal::update($userUuid, $userEntity) === false) {
+                // Set an internal error 500 when we cannot add an entry to the database
+                Http::setHeadersByCode(StatusCode::INTERNAL_SERVER_ERROR);
+
                 // If invalid or got an error, give back an empty response
                 return [];
             }
@@ -101,10 +107,16 @@ public function retrieve(string $userUuid): array
         throw new InvalidValidationException("Invalid user UUID");
     }
 
-    public function remove(object $data): bool
+    /**
+     * @internal Set `mixed` type, because if we get an incorrect payload with syntax errors, `json_decode` gives NULL,
+     * and `object` wouldn't be a valid datatype here.
+     */
+    public function remove(mixed $data): bool
     {
         $userValidation = new UserValidation($data);
         if ($userValidation->isRemoveSchemaValid()) {
+            // Send a 204 if the user got removed
+            //Http::setHeadersByCode(StatusCode::NO_CONTENT);
             return UserDal::remove($data->userUuid);
         }
 

src/routes/user.routes.php

@@ -10,7 +10,7 @@
 enum UserAction: string
 {
     case CREATE = 'create';
-    case RETRIEVE_ALL = 'retrieveAll';
+    case RETRIEVE_ALL = 'retrieveall';
     case RETRIEVE = 'retrieve';
     case REMOVE = 'remove';
     case UPDATE = 'update';
@@ -26,11 +26,11 @@ public function getResponse(): string
         $user = new User();
         try {
             $response = match ($this) {
-                self::CREATE => $user->create($postBody), // TODO Add send 201
-                self::RETRIEVE_ALL => $user->retrieveAll(), // TODO send 200
-                self::RETRIEVE => $user->retrieve($userId), // TODO send 200
-                self::REMOVE => $user->remove($postBody), // TODO send 204 status code
-                self::UPDATE => $user->update($postBody), // TODO send 200
+                self::CREATE => $user->create($postBody),
+                self::RETRIEVE_ALL => $user->retrieveAll(),
+                self::RETRIEVE => $user->retrieve($userId),
+                self::REMOVE => $user->remove($postBody),
+                self::UPDATE => $user->update($postBody),
             };
         } catch (InvalidValidationException $e) {
             // Send 400 http status code