Handling stdClass and other datasource objects

[mabar]

Description

Currently if processor is given an output from json_decode($value), an stdClass is casted to array in case it's in place of a MappedObjectValue. But stdClass makes sense to handle also in case of an ArrayOf and a ListOf.

Handling should be also available in Value in case printer decides to print an invalid value.

We should also consider that fix on user side is as simple as json_decode($value, true) and that it may work only for some formats:

• neon may use an entity which extends stdClass and adds an extra properties.
• xml may be returned as e.g. a SimpleXMLElement and we have no way of casting it to an array, handling attributes or printing errors while maintaining the original xml structure

Addition information

No response

Related issues

No response

[mabar]

jms/serializer has Xml* attributes for that - see https://jmsyst.com/libs/serializer/master/reference/annotations

use JMS\Serializer\Annotation\XmlAttribute;
use JMS\Serializer\Annotation\XmlValue;
use JMS\Serializer\Annotation\XmlRoot;

/** @XmlRoot("price") */
class Price
{
    /** @XmlAttribute */
    private $currency = 'EUR';

    /** @XmlValue */
    private $amount = 1.23;
}

XmlValue should probably be default

[mabar]

symfony/serializer does something similar too, but the exact format should be mainly declared by the object and not in global config
https://symfony.com/doc/current/components/serializer.html#the-xmlencoder

[mabar]

For now I removed support for stdClass from processor. Proper support for various formats will be implemented later 5edbc1a

[mrceperka]

TIL that any stdClass in $data will cause validation to fail. But it will not tell you where it failed.

Most like this to blame:

object-mapper/src/Processing/DefaultProcessor.php

Line 220 in e974721

private function ensureDataProcessable($data, MappedObjectContext $context): array

I might add a test case for this and we might also want to add error to type when this happens.

object-mapper/src/Processing/DefaultProcessor.php

Line 224 in e974721

$type->markInvalid();

[mabar]

TIL that any stdClass in $data will cause validation to fail. But it will not tell you where it failed.

@mrceperka It will be probably handled again with proper data types support, but in the meanwhile I think we could add some internal debug info.
Also I am planning to add invalid value sampling to the printers, but object support will be quite limited, to prevent exposing implementation details via APIs (probably will just say it is an object, no matter of which type)

[mabar]

As mentioned in #73 data types support may include rules for mapping specific data types (JsonRule, XmlRule) to allow decoding inner jsons and perhaps even mapping them.

For both data type rules and manual decoding in callbacks there should be a way to mark the data type in Type interface so printer could properly disclose that the property is encoded as json and not a part of the outer structure.