Address review comments

Author: russgold

operator/src/main/java/oracle/kubernetes/operator/helpers/JobHelper.java

@@ -145,11 +145,15 @@ public NextAction apply(Packet packet) {
   }
 
   private static boolean runIntrospector(Packet packet, DomainPresenceInfo info) {
-    WlsDomainConfig config = (WlsDomainConfig) packet.get(ProcessingConstants.DOMAIN_TOPOLOGY);
-    LOGGER.fine("runIntrospector topology: " + config);
+    WlsDomainConfig topology = (WlsDomainConfig) packet.get(ProcessingConstants.DOMAIN_TOPOLOGY);
+    LOGGER.fine("runIntrospector topology: " + topology);
     LOGGER.fine("runningServersCount: " + runningServersCount(info));
     LOGGER.fine("creatingServers: " + creatingServers(info));
-    return config == null || (runningServersCount(info) == 0 && creatingServers(info));
+    return topology == null || isBringingUpNewDomain(info);
+  }
+
+  private static boolean isBringingUpNewDomain(DomainPresenceInfo info) {
+    return runningServersCount(info) == 0 && creatingServers(info);
   }
 
   private static int runningServersCount(DomainPresenceInfo info) {

operator/src/main/java/oracle/kubernetes/operator/logging/LoggingFactory.java

@@ -1,4 +1,4 @@
-// Copyright 2017, Oracle Corporation and/or its affiliates.  All rights reserved.
+// Copyright 2017, 2019, Oracle Corporation and/or its affiliates.  All rights reserved.
 // Licensed under the Universal Permissive License v 1.0 as shown at
 // http://oss.oracle.com/licenses/upl.
 

operator/src/test/java/oracle/kubernetes/operator/JobWatcherTest.java

@@ -1,4 +1,4 @@
-// Copyright 2018, Oracle Corporation and/or its affiliates.  All rights reserved.
+// Copyright 2018, 2019, Oracle Corporation and/or its affiliates.  All rights reserved.
 // Licensed under the Universal Permissive License v 1.0 as shown at
 // http://oss.oracle.com/licenses/upl.
 

operator/src/test/java/oracle/kubernetes/operator/work/FiberTestSupport.java

@@ -86,6 +86,11 @@ public boolean hasItemScheduledAt(int time, TimeUnit unit) {
     return schedule.containsItemAt(time, unit);
   }
 
+  /**
+   * Returns the engine used by this support object.
+   *
+   * @return the current engine object
+   */
   public Engine getEngine() {
     return engine;
   }