OWLS-74223 : ITUsabilityOperatorHelmChart.testCreateWithMissingTargetDomainInstall test fails.

The problem was that the override file had domainNamespaces:[], which is an empty set and causes the .domain-namespaces.tpl to skip the generation of the namespace role binding.  This, in turn, caused the operator HealthCheckHelper to take much longer and timeout. Fix the test so that it generates the helm override values.yaml file without a domainNamespace at all so that he operator default value is used.  Also, add a new test which passes an empty string as the domainNamespaces entry, this simulates the QuickStart install instructions where --set "domainNamespaces={}" is used.

Author: pfmackin

integration-tests/src/test/java/oracle/kubernetes/operator/ITUsabilityOperatorHelmChart.java

@@ -536,7 +536,41 @@ public void testCreateChartWithInvalidAttributesNegativeInstall() throws Excepti
   }
 
   /**
-   * Helm will install the operator with empty target domains namespaces
+   * Helm will install the operator with no override for domainNamespaces, resulting in the use of
+   * "default" as the target namespace. NOTE: This test must not override domainNamespaces with an
+   * empty set or the operator will fail when it performs security checks because the RoleBinding
+   * for the weblogic-operator-rolebinding-namespace will be missing. Rather, just remove the
+   * domainNamespaces override completely so that we pick up the Operator defaults specified in the
+   * Operator helm chart values.yaml.
+   *
+   * @throws Exception
+   */
+  @Test
+  public void testCreateWithMissingTargetDomainInstall() throws Exception {
+    Assume.assumeFalse(QUICKTEST);
+    String testMethodName = new Object() {}.getClass().getEnclosingMethod().getName();
+    logTestBegin(testMethodName);
+    Operator operator = null;
+    try {
+      Map<String, Object> operatorMap = TestUtils.createOperatorMap(number, true);
+      operatorMap.remove("domainNamespaces");
+      operator = new Operator(operatorMap, RESTCertType.SELF_SIGNED);
+      operator.callHelmInstall();
+      operator.verifyOperatorReady();
+
+    } finally {
+      number++;
+      if (operator != null) {
+        operator.destroy();
+      }
+    }
+    logger.info("SUCCESS - " + testMethodName);
+  }
+
+  /**
+   * Helm will install the operator with empty string as target domains namespaces. This is
+   * equivalent to what the QuickStart guide does when it installs the operator with ' --set
+   * "domainNamespaces={}" '
    *
    * @throws Exception
    */
@@ -549,6 +583,7 @@ public void testCreateWithEmptyTargetDomainInstall() throws Exception {
     try {
       Map<String, Object> operatorMap = TestUtils.createOperatorMap(number, true);
       ArrayList<String> targetDomainsNS = new ArrayList<String>();
+      targetDomainsNS.add("");
       operatorMap.replace("domainNamespaces", targetDomainsNS);
       operator = new Operator(operatorMap, RESTCertType.SELF_SIGNED);
       operator.callHelmInstall();

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Operator.java

@@ -483,12 +483,14 @@ private void initialize(
       // create domain namespaces
 
       ArrayList<String> domainNamespaces = (ArrayList<String>) operatorMap.get("domainNamespaces");
-      for (int i = 0; i < domainNamespaces.size(); i++) {
-        String domainNS = domainNamespaces.get(i);
-        logger.info("domainNamespace " + domainNS);
-        if (!domainNS.equals("default")) {
-          logger.info("Creating domain namespace " + domainNS);
-          ExecCommand.exec("kubectl create namespace " + domainNS);
+      if (domainNamespaces != null) {
+        for (int i = 0; i < domainNamespaces.size(); i++) {
+          String domainNS = domainNamespaces.get(i);
+          logger.info("domainNamespace " + domainNS);
+          if (!domainNS.equals("default")) {
+            logger.info("Creating domain namespace " + domainNS);
+            ExecCommand.exec("kubectl create namespace " + domainNS);
+          }
         }
       }
     }