Skip to content

Commit 72233db

Browse files
doxiaorjeberhard
authored andcommitted
Address another review comment
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
1 parent 152fde1 commit 72233db

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

kubernetes/samples/scripts/common/utility.sh

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -281,12 +281,6 @@ function createFiles {
281281
domainHomeImageBuildPath="./docker-images/OracleWebLogic/samples/12213-domain-home-in-image"
282282
fi
283283

284-
# calculate the internal name to tag the generated image
285-
defaultImageName="`basename ${domainHomeImageBuildPath} | sed 's/^[0-9]*-//'`"
286-
baseTag=${domainHomeImageBase#*:}
287-
288-
defaultImageName=${defaultImageName}:${baseTag:-"latest"}
289-
290284
# Generate the properties file that will be used when creating the weblogic domain
291285
echo Generating ${domainPropertiesOutput}
292286

@@ -303,8 +297,16 @@ function createFiles {
303297
sed -i -e "s:%JAVA_OPTIONS%:${javaOptions}:g" ${domainPropertiesOutput}
304298
sed -i -e "s:%T3_CHANNEL_PORT%:${t3ChannelPort}:g" ${domainPropertiesOutput}
305299
sed -i -e "s:%T3_PUBLIC_ADDRESS%:${t3PublicAddress}:g" ${domainPropertiesOutput}
306-
sed -i -e "s|%IMAGE_NAME%|${defaultImageName}|g" ${domainPropertiesOutput}
307300

301+
if [ -z "${image}" ]; then
302+
# calculate the internal name to tag the generated image
303+
defaultImageName="`basename ${domainHomeImageBuildPath} | sed 's/^[0-9]*-//'`"
304+
baseTag=${domainHomeImageBase#*:}
305+
defaultImageName=${defaultImageName}:${baseTag:-"latest"}
306+
sed -i -e "s|%IMAGE_NAME%|${defaultImageName}|g" ${domainPropertiesOutput}
307+
else
308+
sed -i -e "s|%IMAGE_NAME%|${image}|g" ${domainPropertiesOutput}
309+
fi
308310
else
309311

310312
createJobOutput="${domainOutputDir}/create-domain-job.yaml"

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/create-domain.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,6 @@ function createDomainHome {
195195

196196
sh ${dockerDir}/build.sh
197197

198-
# if the "image" property is set, tag the image with it too
199-
if [ ! -z $image ]; then
200-
docker tag $defaultImageName $image
201-
fi
202-
203198
if [ "$?" != "0" ]; then
204199
fail "Create domain ${domainName} failed."
205200
fi

0 commit comments

Comments
 (0)