Backport no longer generating domain validation failure for missing image pull secrets

Author: rjeberhard

operator/src/main/java/oracle/kubernetes/weblogic/domain/model/Domain.java

@@ -23,7 +23,6 @@
 import io.kubernetes.client.openapi.models.V1Container;
 import io.kubernetes.client.openapi.models.V1ContainerPort;
 import io.kubernetes.client.openapi.models.V1EnvVar;
-import io.kubernetes.client.openapi.models.V1LocalObjectReference;
 import io.kubernetes.client.openapi.models.V1ObjectMeta;
 import io.kubernetes.client.openapi.models.V1PodSpec;
 import io.kubernetes.client.openapi.models.V1SecretReference;
@@ -1293,9 +1292,6 @@ private void checkReservedIntrospectorVariables(BaseConfiguration configuration,
 
     private void addMissingSecrets(KubernetesResourceLookup resourceLookup) {
       verifySecretExists(resourceLookup, getWebLogicCredentialsSecretName(), SecretType.WebLogicCredentials);
-      for (V1LocalObjectReference reference : getImagePullSecrets()) {
-        verifySecretExists(resourceLookup, reference.getName(), SecretType.ImagePull);
-      }
       for (String secretName : getConfigOverrideSecrets()) {
         verifySecretExists(resourceLookup, secretName, SecretType.ConfigOverride);
       }
@@ -1324,10 +1320,6 @@ && getOpssWalletPasswordSecret() == null) {
 
     }
 
-    private List<V1LocalObjectReference> getImagePullSecrets() {
-      return spec.getImagePullSecrets();
-    }
-
     @SuppressWarnings("SameParameterValue")
     private void verifySecretExists(KubernetesResourceLookup resources, String secretName, SecretType type) {
       if (secretName != null && !resources.isSecretExists(secretName, getNamespace())) {

operator/src/test/java/oracle/kubernetes/weblogic/domain/model/DomainValidationTest.java

@@ -586,15 +586,6 @@ void whenBadWebLogicCredentialsSecretNamespaceSpecified_reportError() {
         contains(stringContainsInOrder("Bad namespace", "badNamespace")));
   }
 
-  @Test
-  void whenImagePullSecretSpecifiedButDoesNotExist_reportError() {
-    configureDomain(domain).withDefaultImagePullSecret(new V1LocalObjectReference().name("no-such-secret"));
-
-    assertThat(domain.getValidationFailures(resourceLookup),
-        contains(stringContainsInOrder("ImagePull", "no-such-secret", "not found", NS)));
-
-  }
-
   @Test
   void whenImagePullSecretExists_dontReportError() {
     resourceLookup.defineResource("a-secret", KubernetesResourceType.Secret, NS);