Variables saved with Cursor.setinputsizes() are now forgotten when an

exception is raised (#411).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -80,6 +80,9 @@ Common Changes
 #)  Improved error message when attempting to access attributes on a connection
     before a connection has been established
     (`issue 385 <https://github.com/oracle/python-oracledb/issues/385>`__).
+#)  The variables saved with :meth:`Cursor.setinputsizes()` are now forgotten
+    when an exception is raised
+    (`issue 411 <https://github.com/oracle/python-oracledb/issues/411>`__).
 #)  Fixed bug when calling :meth:`ConnectParams.set()` with a value of ``None``
     for the ``connectiontype`` and ``session_callback`` parameters. Previously,
     any values set earlier would be improperly cleared and now they are

src/oracledb/impl/base/cursor.pyx

@@ -393,14 +393,17 @@ cdef class BaseCursorImpl:
                 self.bind_style is dict and not isinstance(parameters, dict)
                 or self.bind_style is not dict and isinstance(parameters, dict)
             ):
+                self.set_input_sizes = False
                 errors._raise_err(errors.ERR_MIXED_POSITIONAL_AND_NAMED_BINDS)
 
         # prepare statement, if necessary
-        if prepare_needed:
-            self._prepare(statement, None, True)
+        try:
+            if prepare_needed:
+                self._prepare(statement, None, True)
+        finally:
+            self.set_input_sizes = False
 
         # perform bind
-        self.set_input_sizes = False
         if parameters is not None:
             self.bind_one(cursor, parameters)
 
@@ -417,11 +420,13 @@ cdef class BaseCursorImpl:
         # prepare statement, if necessary
         if statement is None and self.statement is None:
             errors._raise_err(errors.ERR_NO_STATEMENT)
-        elif statement is not None and statement != self.statement:
-            self._prepare(statement, None, True)
+        try:
+            if statement is not None and statement != self.statement:
+                self._prepare(statement, None, True)
+        finally:
+            self.set_input_sizes = False
 
         # perform bind, if applicable
-        self.set_input_sizes = False
         if isinstance(parameters, int):
             num_execs = parameters
             if self.bind_vars is not None:

tests/test_4300_cursor_other.py

@@ -989,6 +989,16 @@ def test_4367(self):
         cursor.parse("insert into TestTempTable (IntCol) values (:1)")
         cursor.execute(None, [1])
 
+    def test_4368(self):
+        "4368 - test cursor.setinputsizes() with early failed execute"
+        self.cursor.setinputsizes(a=int, b=str)
+        with self.assertRaisesFullCode("DPY-2006"):
+            self.cursor.execute("select :c from dual", [5])
+        value = 4368
+        self.cursor.execute("select :d from dual", [value])
+        (fetched_value,) = self.cursor.fetchone()
+        self.assertEqual(fetched_value, value)
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()

tests/test_6300_cursor_other_async.py

@@ -853,6 +853,16 @@ async def test_6349(self):
             )
             await cursor.execute(None, [1])
 
+    async def test_6350(self):
+        "6350 - test cursor.setinputsizes() with early failed execute"
+        self.cursor.setinputsizes(a=int, b=str)
+        with self.assertRaisesFullCode("DPY-2006"):
+            await self.cursor.execute("select :c from dual", [5])
+        value = 4368
+        await self.cursor.execute("select :d from dual", [value])
+        (fetched_value,) = await self.cursor.fetchone()
+        self.assertEqual(fetched_value, value)
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()