Test improvements.

Author: anthony-tuininga

tests/test_3700_var.py

@@ -510,6 +510,35 @@ def test_3731(self):
             simple_var = self.cursor.var(str, convert_nulls=convert_nulls)
             self.assertEqual(simple_var.convert_nulls, convert_nulls)
 
+    def test_3732(self):
+        "3732 - test encoding_errors"
+        str_value = "Я"
+        replacement_char = "�"
+        invalid_bytes = str_value.encode("windows-1251")
+        self.cursor.execute("truncate table TestTempTable")
+        self.cursor.execute(
+            """
+            insert into TestTempTable (IntCol, StringCol1)
+            values (1, utl_raw.cast_to_varchar2(:1))
+            """,
+            [invalid_bytes],
+        )
+        self.conn.commit()
+
+        for arg_name in ["encoding_errors", "encodingErrors"]:
+            with self.subTest(arg_name=arg_name):
+
+                def type_handler(cursor, fetch_info):
+                    args = dict(arraysize=cursor.arraysize)
+                    args[arg_name] = "replace"
+                    return cursor.var(fetch_info.type_code, **args)
+
+                with self.conn.cursor() as cursor:
+                    cursor.outputtypehandler = type_handler
+                    cursor.execute("select StringCol1 from TestTempTable")
+                    (fetched_value,) = cursor.fetchone()
+                    self.assertEqual(fetched_value, replacement_char)
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()

tests/test_5200_sql_parser.py

@@ -194,6 +194,45 @@ def test_5214(self):
         with self.assertRaisesFullCode("DPY-2041"):
             self.cursor.prepare("select q'[something from dual")
 
+    def test_5215_different_space_combinations(self):
+        "5215 - different space combinations with :="
+        self.cursor.prepare(
+            """
+            begin :value2 :=
+                               :a  + :b  +   :c +:a +3; end;
+                               begin :value2
+                               :=
+                               :a + :c +3; end;
+            """
+        )
+        self.assertEqual(self.cursor.bindnames(), ["VALUE2", "A", "B", "C"])
+
+    def test_5216_binds_between_comment_blocks_with_quotes(self):
+        "5216 - bind variables between multiple comment blocks with quotes"
+        self.cursor.prepare(
+            """
+            select
+                /* ' comment 1 */
+                :a,
+                /* "comment " 2 ' */:b
+                /* comment 3 '*/,
+                :c
+                /* comment 4 ""*/
+            from dual
+            """
+        )
+        self.assertEqual(self.cursor.bindnames(), ["A", "B", "C"])
+
+    def test_5217_binds_missing_quote_exception(self):
+        "5217 - query with a missing end quote"
+        with self.assertRaisesFullCode("DPY-2041"):
+            self.cursor.prepare("select 'abc, :a from dual")
+
+    def test_5218_binds_missing_quote_exception(self):
+        "5218 - q-string with wrong closing symbols"
+        with self.assertRaisesFullCode("DPY-2041"):
+            self.cursor.prepare("select q'[abc'], 5 from dual")
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()