Improve thin mode error message for connection pool tagging.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -17,6 +17,11 @@ oracledb `3.3.0 <https://github.com/oracle/python-oracledb/compare/v3.2.0...v3.3
 Thin Mode Changes
 +++++++++++++++++
 
+#)  Error ``DPY-3001: session tagging is only supported in python-oracledb
+    thick mode`` is now raised when attempting to use session tagging with a
+    connection pool. Previously a ``NotImplementedError`` exception was raised
+    instead.
+
 Thick Mode Changes
 ++++++++++++++++++
 

src/oracledb/impl/thin/pool.pyx

@@ -622,7 +622,7 @@ cdef class ThinPoolImpl(BaseThinPoolImpl):
 
         # session tagging has not been implemented yet
         if params.tag is not None:
-            raise NotImplementedError("Tagging has not been implemented yet")
+            errors._raise_not_supported("session tagging")
 
         # wait until an acceptable connection is found
         request = self._create_request(params)
@@ -812,7 +812,7 @@ cdef class AsyncThinPoolImpl(BaseThinPoolImpl):
 
         # session tagging has not been implemented yet
         if params.tag is not None:
-            raise NotImplementedError("Tagging has not been implemented yet")
+            errors._raise_not_supported("session tagging")
 
         # use the helper function to allow for a timeout since asyncio
         # condition variables do not have that capability directly

tests/test_7300_unsupported_features_thin.py

@@ -62,6 +62,12 @@ def test_7303(self):
                 password=test_env.get_main_password(),
             )
 
+    def test_7304(self):
+        "7304 - test acquire() from a pool with a session tag"
+        pool = test_env.get_pool()
+        with self.assertRaisesFullCode("DPY-3001"):
+            pool.acquire(tag="unimportant")
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()