Fixed bug in Connection.tpc_recover() where the returned items were not

of the type returned by Connection.xid() as documented.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -70,6 +70,8 @@ Common Changes
 #)  If both the ``sid`` and ``service_name`` parameters are specified to
     :meth:`oracledb.makedsn()`, now only the ``service_name`` parameter is
     used and the ``sid`` parameter is ignored.
+#)  Fixed bug in :meth:`Connection.tpc_recover()` where the returned items were
+    not of the type returned by :meth:`Connection.xid()` as documented.
 #)  Internal changes to ensure that no circular imports occur.
 
 

src/oracledb/connection.py

@@ -1100,7 +1100,6 @@ def tpc_recover(self) -> list:
         DBA_PENDING_TRANSACTIONS.
         """
         with self.cursor() as cursor:
-            cursor.rowfactory = Xid
             cursor.execute(
                 """
                     select
@@ -1109,6 +1108,7 @@ def tpc_recover(self) -> list:
                         branchid
                     from dba_pending_transactions"""
             )
+            cursor.rowfactory = Xid
             return cursor.fetchall()
 
     def tpc_rollback(self, xid: Xid = None) -> None:

utils/templates/connection.py

@@ -1098,7 +1098,6 @@ def tpc_recover(self) -> list:
         DBA_PENDING_TRANSACTIONS.
         """
         with self.cursor() as cursor:
-            cursor.rowfactory = Xid
             cursor.execute(
                 """
                     select
@@ -1107,6 +1106,7 @@ def tpc_recover(self) -> list:
                         branchid
                     from dba_pending_transactions"""
             )
+            cursor.rowfactory = Xid
             return cursor.fetchall()
 
     def tpc_rollback(self, xid: Xid = None) -> None: