Fixed bug with fetching years < 0 (#345).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -25,6 +25,9 @@ Thin Mode Changes
     ``wait_timeout`` value and the connection request will not additionally be
     delayed by any internal network ping to the database (`issue 330
     <https://github.com/oracle/python-oracledb/issues/330>`__).
+#)  Fixed bug in fetching dates with years less than 0
+    (`issue 345 <https://github.com/oracle/python-oracledb/issues/345>`__).
+
 
 Thick Mode Changes
 ++++++++++++++++++

src/oracledb/impl/base/buffer.pyx

@@ -341,7 +341,7 @@ cdef class Buffer:
             int8_t tz_hour = 0, tz_minute = 0
             uint32_t fsecond = 0
             int32_t seconds
-            uint16_t year
+            int16_t year
         year = (ptr[0] - 100) * 100 + ptr[1] - 100
         if num_bytes >= 11:
             fsecond = unpack_uint32(&ptr[7], BYTE_ORDER_MSB) // 1000

tests/test_1400_datetime_var.py

@@ -297,6 +297,14 @@ def test_1417(self):
         self.assertEqual(self.cursor.fetchone(), self.data_by_key[4])
         self.assertIsNone(self.cursor.fetchone())
 
+    def test_1418(self):
+        "1418 - test fetching a date with year < 0"
+        with self.assertRaises(ValueError):
+            self.cursor.execute(
+                "select to_date('-4712-01-01', 'SYYYY-MM-DD') from dual"
+            )
+            self.cursor.fetchone()
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()