Improved error message when attempting to access attributes on a

connection pool before it has been created (#385).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -84,7 +84,8 @@ Common Changes
 #)  Improved type hints for cursors
     (`issue 391 <https://github.com/oracle/python-oracledb/issues/391>`__).
 #)  Improved error message when attempting to access attributes on a connection
-    before a connection has been established
+    before a connection has been established or a connection pool before it has
+    been created
     (`issue 385 <https://github.com/oracle/python-oracledb/issues/385>`__).
 #)  The variables saved with :meth:`Cursor.setinputsizes()` are now forgotten
     when an exception is raised

src/oracledb/pool.py

@@ -48,6 +48,7 @@
 
 class BaseConnectionPool:
     __module__ = oracledb.__name__
+    _impl = None
 
     def __init__(
         self, dsn: str = None, *, params: PoolParams = None, **kwargs
@@ -77,7 +78,6 @@ def __init__(
         keyword parameters, which themselves override the values set in the
         params parameter object.
         """
-        self._impl = None
         if params is None:
             params_impl = base_impl.PoolParamsImpl()
         elif not isinstance(params, PoolParams):

utils/templates/pool.py

@@ -46,6 +46,7 @@
 
 class BaseConnectionPool:
     __module__ = oracledb.__name__
+    _impl = None
 
     def __init__(
         self, dsn: str = None, *, params: PoolParams = None, **kwargs
@@ -75,7 +76,6 @@ def __init__(
         keyword parameters, which themselves override the values set in the
         params parameter object.
         """
-        self._impl = None
         if params is None:
             params_impl = base_impl.PoolParamsImpl()
         elif not isinstance(params, PoolParams):