use try with resources

Author: vladak

plugins/src/main/java/opengrok/auth/plugin/util/RestfulClient.java

@@ -18,7 +18,7 @@
  */
 
 /*
- * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
  * Portions Copyright (c) 2020, Chris Fraire <cfraire@me.com>.
  */
 package opengrok.auth.plugin.util;
@@ -44,27 +44,28 @@ private RestfulClient() {
     }
 
     /**
-     * Perform HTTP PUT request.
+     * Perform HTTP POST request.
      * @param uri URI
      * @param input JSON string contents
      * @return HTTP status or -1
      */
     public static int postIt(String uri, String input) {
         try {
-            Client client = ClientBuilder.newClient();
+            try (Client client = ClientBuilder.newClient()) {
+                LOGGER.log(Level.FINEST, "sending REST POST request to {0}: {1}",
+                        new Object[]{uri, input});
+                try (Response response = client.target(uri)
+                        .request(MediaType.APPLICATION_JSON)
+                        .post(Entity.entity(input, MediaType.APPLICATION_JSON))) {
 
-            LOGGER.log(Level.FINEST, "sending REST POST request to {0}: {1}",
-                    new Object[]{uri, input});
-            Response response = client.target(uri)
-                    .request(MediaType.APPLICATION_JSON)
-                    .post(Entity.entity(input, MediaType.APPLICATION_JSON));
+                    int status = response.getStatus();
+                    if (status != HttpServletResponse.SC_CREATED) {
+                        LOGGER.log(Level.WARNING, "REST request failed: HTTP error code : {0}", status);
+                    }
 
-            int status = response.getStatus();
-            if (status != HttpServletResponse.SC_CREATED) {
-                LOGGER.log(Level.WARNING, "REST request failed: HTTP error code : {0}", status);
+                    return status;
+                }
             }
-
-            return status;
         } catch (Exception e) {
             LOGGER.log(Level.WARNING, "REST request failed", e);
             return -1;