Skip to content

Commit dd255d7

Browse files
authored
Update comments related to Request.oboToken to clarify that it is only required by Java SDK not by other drivers.(#107)
1 parent 2e0e7df commit dd255d7

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

driver/src/main/java/oracle/nosql/driver/http/Client.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1842,6 +1842,9 @@ private boolean requireContentSigned(Request request) {
18421842
* because in the client it's not known if the operation is on a
18431843
* multi-region table or not. This is a small bit of overhead and
18441844
* is ignored if the table is not multi-region
1845+
*
1846+
* The Request.oboToken is not required by non Java SDKs, remove
1847+
* request.getOboToken() != null if there is no Request.oboToken
18451848
*/
18461849
return request instanceof AddReplicaRequest ||
18471850
request instanceof DropReplicaRequest ||

driver/src/main/java/oracle/nosql/driver/iam/SignatureProvider.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,6 +1086,14 @@ private SignatureDetails getSignatureWithContent(Request request,
10861086
return sigDetails;
10871087
}
10881088

1089+
/*
1090+
* Since Request.oboToken is not required by non Java SDKs, if there
1091+
* is no Request.oboToken, simplify this method as following:
1092+
*
1093+
* private String getDelegationToken(Request req) {
1094+
* return delegationToken;
1095+
* }
1096+
*/
10891097
private String getDelegationToken(Request req) {
10901098
return (req != null && req.getOboToken() != null) ?
10911099
req.getOboToken() : delegationToken;

driver/src/main/java/oracle/nosql/driver/ops/Request.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ public abstract class Request {
8585

8686
/**
8787
* @hidden
88-
* This is only used by internal, cross-region requests
88+
* This is only required by Java SDK for internal cross-region request, not
89+
* by other drivers.
8990
*/
9091
private String oboToken;
9192

@@ -569,7 +570,9 @@ public boolean getDRLOptIn() {
569570

570571
/**
571572
* @hidden
572-
* internal use only
573+
* This is only required by Java SDK for internal cross-region request, not
574+
* by other drivers.
575+
*
573576
* @param token the on-behalf-of token
574577
*/
575578
public void setOboTokenInternal(String token) {
@@ -578,7 +581,9 @@ public void setOboTokenInternal(String token) {
578581

579582
/**
580583
* @hidden
581-
* internal use only
584+
* This is only required by Java SDK for internal cross-region request, not
585+
* by other drivers.
586+
*
582587
* @return the on-behalf-of token
583588
*/
584589
public String getOboToken() {

0 commit comments

Comments
 (0)