Created new connection pool with simplified configuration and the ability

to keep cloud service connections alive when idle

Author: gmfeinberg

.classpath

@@ -1,16 +1,25 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
+		<attributes>
+			<attribute name="module" value="true"/>
+		</attributes>
+	</classpathentry>
 	<classpathentry kind="src" path="driver/src/main/java"/>
 	<classpathentry kind="src" path="driver/src/test/java"/>
 	<classpathentry kind="src" path="examples/src/main/java"/>
 	<classpathentry kind="lib" path="driver/target/nosqldriver.jar"/>
 	<classpathentry kind="lib" path="examples/target/nosql-java-sdk-examples.jar"/>
+	<classpathentry kind="var" path="M2_REPO/com/fasterxml/jackson/core/jackson-core/2.12.4/jackson-core-2.12.4.jar"/>	<classpathentry kind="var" path="M2_REPO/io/netty/netty-buffer/4.1.74.Final/netty-buffer-4.1.74.Final.jar"/>
+        <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec/4.1.74.Final/netty-codec-4.1.74.Final.jar"/>
+        <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec-http/4.1.74.Final/netty-codec-http-4.1.74.Final.jar"/>
+        <classpathentry kind="var" path="M2_REPO/io/netty/netty-common/4.1.74.Final/netty-common-4.1.74.Final.jar"/>
+        <classpathentry kind="var" path="M2_REPO/io/netty/netty-handler/4.1.74.Final/netty-handler-4.1.74.Final.jar"/>
+        <classpathentry kind="var" path="M2_REPO/io/netty/netty-handler-proxy/4.1.74.Final/netty-handler-proxy-4.1.74.Final.jar"/>
+        <classpathentry kind="var" path="M2_REPO/io/netty/netty-transport/4.1.74.Final/netty-transport-4.1.74.Final.jar"/>
+	<classpathentry kind="var" path="M2_REPO/org/bouncycastle/bcprov-jdk15on/1.68/bcprov-jdk15on-1.68.jar"/>
+	<classpathentry kind="var" path="M2_REPO/org/bouncycastle/bcpkix-jdk15on/1.68/bcpkix-jdk15on-1.68.jar"/>
+	<classpathentry kind="var" path="M2_REPO/junit/junit/4.11/junit-4.11.jar"/>
+	<classpathentry kind="var" path="M2_REPO/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar"/>
 	<classpathentry kind="output" path="driver/target/classes"/>
-        <classpathentry kind="var" path="M2_REPO/com/fasterxml/jackson/core/jackson-core/2.11.2/jackson-core-2.11.2.jar"/>
-        <classpathentry kind="var" path="M2_REPO/io/netty/netty-all/4.1.45.Final/netty-all-4.1.45.Final.jar"/>
-        <classpathentry kind="var" path="M2_REPO/org/bouncycastle/bcprov-jdk15on/1.66/bcprov-jdk15on-1.66.jar"/>
-        <classpathentry kind="var" path="M2_REPO/org/bouncycastle/bcpkix-jdk15on/1.66/bcpkix-jdk15on-1.66.jar"/>
-        <classpathentry kind="var" path="M2_REPO/junit/junit/4.11/junit-4.11.jar"/>
-        <classpathentry kind="var" path="M2_REPO/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar"/>
 </classpath>

CHANGELOG.md

@@ -5,10 +5,21 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
 ## [Unpublished]
 
 ### Added
+- new methods in NoSQLHandleConfig to control keeping a minimum number of connections alive in the connection pool
+ - get/setConnectionPoolMinSize
 - Added new methods in NoSQLHandleConfig to control the SSL handshake timeout,
 default 3000 milliseconds.
   - get/setSslHandshakeTimeout
 
+### Deprecated
+- several methods in NoSQLHandleConfig are deprecated as they have no effect on the new connection pool implementation. The methods remain, temporarily, but they do not control the pool
+ - get/setConnectionPoolSize
+ - get/setPoolMaxPending
+
+### Changed
+- there is a new connection pool implementation to simplify management of connections by reducing the need for configuration. The new pool will create new connections on demand, with no maximum.  It will also remove them to the configured minimum (default 0) after a period of inactivity
+- the new connection pool will send periodic keep-alive style HTTP requests to maintain activity level. These requests are only sent if a minimum size is configured using NoSQLHandleConfig.setConnectionPoolMinSize. This mechanism is mostly useful in the cloud service because the server side will close idle connections. Creating new connections requires a new SSL handshake and can add latency to requests after idle time.
+
 ### Fixed
 - Cloud only: Fixed an issue that a request may have unexpected latency when
 authenticated with instance/resource principal due to security token refresh.

driver/.classpath

@@ -1,19 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
   <classpathentry kind="src" path="src/test/java" output="target/test-classes" including="**/*.java"/>
+  <classpathentry kind="src" path="src/test/resources" output="target/test-classes" excluding="**/*.java"/>
   <classpathentry kind="src" path="src/main/java" including="**/*.java"/>
   <classpathentry kind="output" path="target/classes"/>
   <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
-  <classpathentry kind="var" path="M2_REPO/com/fasterxml/jackson/core/jackson-core/2.12.1/jackson-core-2.12.1.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-buffer/4.1.71.Final/netty-buffer-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-common/4.1.71.Final/netty-common-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec-http/4.1.71.Final/netty-codec-http-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-transport/4.1.71.Final/netty-transport-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-resolver/4.1.71.Final/netty-resolver-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec/4.1.71.Final/netty-codec-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-handler/4.1.71.Final/netty-handler-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-handler-proxy/4.1.71.Final/netty-handler-proxy-4.1.71.Final.jar"/>
-  <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec-socks/4.1.71.Final/netty-codec-socks-4.1.71.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/com/fasterxml/jackson/core/jackson-core/2.12.4/jackson-core-2.12.4.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-buffer/4.1.74.Final/netty-buffer-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-common/4.1.74.Final/netty-common-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec-http/4.1.74.Final/netty-codec-http-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-transport/4.1.74.Final/netty-transport-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-resolver/4.1.74.Final/netty-resolver-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec/4.1.74.Final/netty-codec-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-handler/4.1.74.Final/netty-handler-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-tcnative-classes/2.0.48.Final/netty-tcnative-classes-2.0.48.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-handler-proxy/4.1.74.Final/netty-handler-proxy-4.1.74.Final.jar"/>
+  <classpathentry kind="var" path="M2_REPO/io/netty/netty-codec-socks/4.1.74.Final/netty-codec-socks-4.1.74.Final.jar"/>
   <classpathentry kind="var" path="M2_REPO/org/bouncycastle/bcprov-jdk15on/1.68/bcprov-jdk15on-1.68.jar"/>
   <classpathentry kind="var" path="M2_REPO/org/bouncycastle/bcpkix-jdk15on/1.68/bcpkix-jdk15on-1.68.jar"/>
   <classpathentry kind="var" path="M2_REPO/junit/junit/4.13.1/junit-4.13.1.jar"/>

driver/.project

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <projectDescription>
   <name>nosqldriver</name>
-  <comment>NO_M2ECLIPSE_SUPPORT: Project files created with the maven-eclipse-plugin are not supported in M2Eclipse.</comment>
+  <comment>This project contains the SDK used for Oracle NoSQL Database. NO_M2ECLIPSE_SUPPORT: Project files created with the maven-eclipse-plugin are not supported in M2Eclipse.</comment>
   <projects/>
   <buildSpec>
     <buildCommand>

driver/.settings/org.eclipse.jdt.core.prefs

@@ -1,4 +1,4 @@
-#Mon Nov 02 16:24:58 EST 2020
+#Sat Feb 26 21:45:00 EST 2022
 org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8
 org.eclipse.jdt.core.compiler.source=1.8
 eclipse.preferences.version=1

driver/pom.xml

@@ -29,7 +29,7 @@
 
   <groupId>com.oracle.nosql.sdk</groupId>
   <artifactId>nosqldriver</artifactId>
-  <version>5.3.1</version>
+  <version>5.3.2-SNAPSHOT</version>
   <packaging>jar</packaging>
 
   <organization>
@@ -91,7 +91,7 @@
           ConfigFileTest.java, SignatureProviderTest.java,
           UserProfileProviderTest.java, InstancePrincipalsProviderTest.java,
           HandleConfigTest.java, JsonTest.java, ValueTest.java,
-          OnPremiseTest.java
+          OnPremiseTest.java, ConnectionPoolTest.java
         </excluded.tests>
       </properties>
     </profile>
@@ -108,7 +108,7 @@
           StoreAccessTokenProviderTest.java, ResourcePrincipalProviderTest.java,
           ConfigFileTest.java, SignatureProviderTest.java,
           UserProfileProviderTest.java, InstancePrincipalsProviderTest.java,
-          HandleConfigTest.java, JsonTest.java, ValueTest.java
+          HandleConfigTest.java, JsonTest.java, ValueTest.java, ConnectionPoolTest.java
         </excluded.tests>
       </properties>
     </profile>