Skip to content

Commit 1663231

Browse files
gmfeinberggmfeinberg
committed
Small enhancements to README and pom
Fix typo in test code
1 parent 88095de commit 1663231

File tree

3 files changed

+42
-35
lines changed

3 files changed

+42
-35
lines changed

‎README.md‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ See [Oracle NoSQL SDK for Java javadoc](https://oracle.github.io/nosql-java-sdk/
5555
General documentation about the Oracle NoSQL Database and the Oracle NoSQL Database Cloud Service can be found in these locations:
5656

5757
* [Oracle NoSQL Database Cloud Service](https://docs.oracle.com/en/cloud/paas/nosql-cloud/nosql_dev.html)
58-
* [Oracle NoSQL Database](https://www.oracle.com/database/technologies/related/nosql.html)
58+
* [Oracle NoSQL Database On Premise](https://docs.oracle.com/en/database/other-databases/nosql-database/)
5959

6060
## Connect to the Oracle NoSQL Database
6161

@@ -380,6 +380,13 @@ $ mvn -pl examples exec:java -Dexec.mainClass=BasicTableExample \
380380
-Dexec.args="http://localhost:8090 -useKVProxy"
381381
```
382382

383+
Run BasicTableExample using the cloud service on region us-ashburn-1
384+
385+
```
386+
$ mvn -pl examples exec:java -Dexec.mainClass=BasicTableExample \
387+
-Dexec.args="us-ashburn-1"
388+
```
389+
383390
### Compile and Run Examples using a Downloaded Release
384391

385392
Compile Examples:

‎driver/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
6-
<name>Oracle NoSQL Database SDK Driver</name>
6+
<name>Oracle NoSQL Database SDK for Java</name>
77
<description>Java examples for Oracle NoSQL Database</description>
88

99
<groupId>com.oracle.nosql.sdk</groupId>

‎driver/src/test/java/oracle/nosql/driver/NumericTest.java‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -134,32 +134,32 @@ public void testCompatibleTypes() {
134134

135135
value.put(fname, longToIntOK);
136136
expValues.put(fname, (int)longToIntOK);
137-
putAsOtherNuermicTypeTest(value, true, expValues);
137+
putAsOtherNumericTypeTest(value, true, expValues);
138138

139139
value.put(fname, longToIntFail);
140-
putAsOtherNuermicTypeTest(value, false);
140+
putAsOtherNumericTypeTest(value, false);
141141

142142
/* Use DOUBLE for Integer type */
143143
final double doubleToIntOK = 1.2345678E7d;
144144
final double doubleToIntFail = -1.1d;
145145

146146
value.put(fname, doubleToIntOK);
147147
expValues.put(fname, (int)doubleToIntOK);
148-
putAsOtherNuermicTypeTest(value, true, expValues);
148+
putAsOtherNumericTypeTest(value, true, expValues);
149149

150150
value.put(fname, doubleToIntFail);
151-
putAsOtherNuermicTypeTest(value, false);
151+
putAsOtherNumericTypeTest(value, false);
152152

153153
/* Use NUMBER for Integer type */
154154
final BigDecimal decimalToIntOK = BigDecimal.valueOf(Integer.MIN_VALUE);
155155
final BigDecimal decimalToIntFail = BigDecimal.valueOf(Long.MAX_VALUE);
156156

157157
value.put(fname, decimalToIntOK);
158158
expValues.put(fname, decimalToIntOK.intValue());
159-
putAsOtherNuermicTypeTest(value, true, expValues);
159+
putAsOtherNumericTypeTest(value, true, expValues);
160160

161161
value.put(fname, decimalToIntFail);
162-
putAsOtherNuermicTypeTest(value, false);
162+
putAsOtherNumericTypeTest(value, false);
163163

164164
/*
165165
* Target KV field type: Long
@@ -174,29 +174,29 @@ public void testCompatibleTypes() {
174174

175175
value.put(fname, intToLongOK);
176176
expValues.put(fname, (long)intToLongOK);
177-
putAsOtherNuermicTypeTest(value, true, expValues);
177+
putAsOtherNumericTypeTest(value, true, expValues);
178178

179179
/* Use DOUBLE for Long type */
180180
final double doubleToLongOK = 1.234567890123E12d;
181181
final double doubleToLongFail = -1.1d;
182182

183183
value.put(fname, doubleToLongOK);
184184
expValues.put(fname, (long)doubleToLongOK);
185-
putAsOtherNuermicTypeTest(value, true, expValues);
185+
putAsOtherNumericTypeTest(value, true, expValues);
186186

187187
value.put(fname, doubleToLongFail);
188-
putAsOtherNuermicTypeTest(value, false);
188+
putAsOtherNumericTypeTest(value, false);
189189

190190
/* Use NUMBER for Long type */
191191
final BigDecimal decimalToLongOK = BigDecimal.valueOf(Long.MAX_VALUE);
192192
final BigDecimal decimalToLongFail = new BigDecimal("1234567890.1");
193193

194194
value.put(fname, decimalToLongOK);
195195
expValues.put(fname, decimalToLongOK.longValue());
196-
putAsOtherNuermicTypeTest(value, true, expValues);
196+
putAsOtherNumericTypeTest(value, true, expValues);
197197

198198
value.put(fname, decimalToLongFail);
199-
putAsOtherNuermicTypeTest(value, false);
199+
putAsOtherNumericTypeTest(value, false);
200200

201201
/*
202202
* Target KV field type: Float
@@ -212,32 +212,32 @@ public void testCompatibleTypes() {
212212

213213
value.put(fname, intToFloatOK);
214214
expValues.put(fname, (double)intToFloatOK);
215-
putAsOtherNuermicTypeTest(value, true, expValues);
215+
putAsOtherNumericTypeTest(value, true, expValues);
216216

217217
value.put(fname, intToFloatFail);
218-
putAsOtherNuermicTypeTest(value, false);
218+
putAsOtherNumericTypeTest(value, false);
219219

220220
/* Use LONG for Float type */
221221
final long longToFloatOK = Long.MAX_VALUE;
222222
final long longToFloatFail = Long.MAX_VALUE - 1;
223223

224224
value.put(fname, longToFloatOK);
225225
expValues.put(fname, (double)longToFloatOK);
226-
putAsOtherNuermicTypeTest(value, true, expValues);
226+
putAsOtherNumericTypeTest(value, true, expValues);
227227

228228
value.put(fname, longToFloatFail);
229-
putAsOtherNuermicTypeTest(value, false);
229+
putAsOtherNumericTypeTest(value, false);
230230

231231
/* Use DOUBLE for Float type */
232232
final double doubleToFloatOK = -Float.MAX_VALUE;
233233
final double doubleToFloatFail = Double.MAX_VALUE;
234234

235235
value.put(fname, doubleToFloatOK);
236236
expValues.put(fname, doubleToFloatOK);
237-
putAsOtherNuermicTypeTest(value, true, expValues);
237+
putAsOtherNumericTypeTest(value, true, expValues);
238238

239239
value.put(fname, doubleToFloatFail);
240-
putAsOtherNuermicTypeTest(value, false);
240+
putAsOtherNumericTypeTest(value, false);
241241

242242
/* Use NUMBER for Float type */
243243
float flt = 1.23456E2f;
@@ -247,10 +247,10 @@ public void testCompatibleTypes() {
247247

248248
value.put(fname, decimalToFloatOK);
249249
expValues.put(fname, (double)flt);
250-
putAsOtherNuermicTypeTest(value, true, expValues);
250+
putAsOtherNumericTypeTest(value, true, expValues);
251251

252252
value.put(fname, decimalToFloatFail);
253-
putAsOtherNuermicTypeTest(value, false);
253+
putAsOtherNumericTypeTest(value, false);
254254

255255
/*
256256
* Target KV field type: Double
@@ -265,18 +265,18 @@ public void testCompatibleTypes() {
265265

266266
value.put(fname, intToDoubleOK);
267267
expValues.put(fname, (double)intToDoubleOK);
268-
putAsOtherNuermicTypeTest(value, true, expValues);
268+
putAsOtherNumericTypeTest(value, true, expValues);
269269

270270
/* Use LONG for Double type */
271271
final long longToDoubleOK = Long.MAX_VALUE;
272272
final long longToDoubleFail = Long.MAX_VALUE - 1;
273273

274274
value.put(fname, longToDoubleOK);
275275
expValues.put(fname, (double)longToDoubleOK);
276-
putAsOtherNuermicTypeTest(value, true, expValues);
276+
putAsOtherNumericTypeTest(value, true, expValues);
277277

278278
value.put(fname, longToDoubleFail);
279-
putAsOtherNuermicTypeTest(value, false);
279+
putAsOtherNumericTypeTest(value, false);
280280

281281
/* Use NUMBER for Double type */
282282
double dbl = Double.MAX_VALUE;
@@ -286,10 +286,10 @@ public void testCompatibleTypes() {
286286

287287
value.put(fname, decimalToDoubleOK);
288288
expValues.put(fname, dbl);
289-
putAsOtherNuermicTypeTest(value, true, expValues);
289+
putAsOtherNumericTypeTest(value, true, expValues);
290290

291291
value.put(fname, decimalToDoubleFail);
292-
putAsOtherNuermicTypeTest(value, false);
292+
putAsOtherNumericTypeTest(value, false);
293293

294294
/*
295295
* Target KV field type: Number
@@ -303,19 +303,19 @@ public void testCompatibleTypes() {
303303
final int intToNumberOK = Integer.MAX_VALUE;
304304
value.put(fname, intToNumberOK);
305305
expValues.put(fname, BigDecimal.valueOf(intToNumberOK));
306-
putAsOtherNuermicTypeTest(value, true, expValues);
306+
putAsOtherNumericTypeTest(value, true, expValues);
307307

308308
/* Use LONG for Number type */
309309
final long longToNumberOK = Long.MAX_VALUE;
310310
value.put(fname, longToNumberOK);
311311
expValues.put(fname, BigDecimal.valueOf(longToNumberOK));
312-
putAsOtherNuermicTypeTest(value, true, expValues);
312+
putAsOtherNumericTypeTest(value, true, expValues);
313313

314314
/* Use DOUBLE for Number type */
315315
final double doubleToNumberOK = Double.MAX_VALUE;
316316
value.put(fname, doubleToNumberOK);
317317
expValues.put(fname, BigDecimal.valueOf(doubleToNumberOK));
318-
putAsOtherNuermicTypeTest(value, true, expValues);
318+
putAsOtherNumericTypeTest(value, true, expValues);
319319
}
320320

321321
/*
@@ -398,21 +398,21 @@ private void runGetDeleteTest(String tname,
398398
assertTrue(expSucceed == delRes.getSuccess());
399399
}
400400

401-
private void putAsOtherNuermicTypeTest(MapValue value,
401+
private void putAsOtherNumericTypeTest(MapValue value,
402402
boolean shouldSucceed) {
403403

404-
putAsOtherNuermicTypeTest(value, shouldSucceed, null);
404+
putAsOtherNumericTypeTest(value, shouldSucceed, null);
405405
}
406406

407-
private void putAsOtherNuermicTypeTest(MapValue value,
407+
private void putAsOtherNumericTypeTest(MapValue value,
408408
boolean shouldSucceed,
409409
Map<String, Object> expValues) {
410410

411-
runPutAsOtherNuermicTypeTest(value, false, shouldSucceed, expValues);
412-
runPutAsOtherNuermicTypeTest(value, true, shouldSucceed, expValues);
411+
runPutAsOtherNumericTypeTest(value, false, shouldSucceed, expValues);
412+
runPutAsOtherNumericTypeTest(value, true, shouldSucceed, expValues);
413413
}
414414

415-
private void runPutAsOtherNuermicTypeTest(MapValue value,
415+
private void runPutAsOtherNumericTypeTest(MapValue value,
416416
boolean numericAsNumber,
417417
boolean shouldSucceed,
418418
Map<String, Object> expValues){

0 commit comments

Comments
 (0)