Fix for GH issue #1625 - Bug with multi-line comments with multiple asterisks

Author: sharadraju

doc/src/release_notes.rst

@@ -52,6 +52,10 @@ Common Changes
 Thin Mode Changes
 ++++++++++++++++++
 
+#)  Fixed bug in parsing SQL statements containing multi-line comments
+    with multiple asterisks before the closing slash.
+    `Issue #1625 <https://github.com/oracle/node-oracledb/issues/1625>`__.
+
 #)  Fixed bug that caused an 'ORA-03120' exception to be thrown when
     a string whose size is greater than "database initialization parameter",
     ``MAX_STRING_SIZE`` is bound to a PL/SQL function.

lib/thin/statement.js

@@ -142,7 +142,7 @@ class Parser {
           break;
         }
         inComment = true;
-      } else if (!exitingComment && ch === '*') {
+      } else if (ch === '*') {
         exitingComment = true;
       } else if (exitingComment) {
         if (ch === '/') {

test/getStmtInfo.js

@@ -481,4 +481,16 @@ describe('162. getStmtInfo.js', function() {
       key = key + 1;
     }
   });
+
+  it('162.36 Multiple line and Multiple Asterisks', async function() {
+    const sql = `/****--select * from :a where :a = 1
+    select * from table_names where :a = 1****/
+    select :table_name, :value from dual`;
+    const expectedRes = ['TAB', 'VAL'];
+
+    const info = await conn.getStatementInfo(sql);
+    assert.deepStrictEqual(info.bindNames, ['TABLE_NAME', 'VALUE']);
+    const result = await conn.execute(sql, expectedRes);
+    assert.deepStrictEqual(result.rows[0], expectedRes);
+  });
 });

test/list.txt

@@ -4159,6 +4159,7 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
     162.33 Bind Variable before, inbetween and after comments in sql
     162.34 ignore literals only during bind processing
     162.35 Parse and Execute twice
+    162.36 Multiple line and Multiple Asterisks
 
 163. executeMany1.js
     163.1 inserts many rows with bind by name