Pool and error optimizations and standardizations

Author: sharadraju

lib/errors.js

@@ -355,7 +355,7 @@ messages.set(ERR_UNSUPPORTED_VERIFIER_TYPE,             // NJS-116
 messages.set(ERR_INVALID_PRIVATE_KEY,                   // NJS-117
   'invalid private key. Headers and footers are not allowed');
 messages.set(ERR_THIN_CONNECTION_ALREADY_CREATED,       // NJS-118
-  'node-oracledb Thick mode cannot be used because a Thin mode connection has already been created');
+  'node-oracledb Thick mode cannot be enabled because a Thin mode connection has already been created');
 messages.set(ERR_UNSUPPORTED_CONVERSION,                // NJS-119
   'conversion from type %s to type %s is not supported');
 messages.set(ERR_FETCH_TYPE_HANDLER_RETURN_VALUE,       // NJS-120

lib/oracledb.js

@@ -373,10 +373,10 @@ async function _verifyOptions(options, inCreatePool) {
       outOptions.queueTimeout = options.queueTimeout;
     }
 
-    // queueMax must be an integer >= 0
+    // queueMax must be an integer >= -1
     if (options.queueMax !== undefined) {
       errors.assertParamPropValue(Number.isInteger(options.queueMax) &&
-        options.queueMax >= 0, 1, "queueMax");
+        options.queueMax >= -1, 1, "queueMax");
       outOptions.queueMax = options.queueMax;
     }
 

test/pool.js

@@ -502,6 +502,45 @@ describe('2. pool.js', function() {
       await pool.close(0);
     });
 
+    it('2.8.6 queueMax range check, queueMax -1', async function() {
+      const config = {...dbConfig,
+        poolMin           : 1,
+        poolMax           : 1,
+        poolIncrement     : 0,
+        queueMax          : -1
+      };
+      const pool = await oracledb.createPool(config);
+      const conn = await pool.getConnection();
+      await conn.close();
+      await pool.close(0);
+    });
+
+    it('2.8.7 queueMax range check, queueMax -2 out of range', async function() {
+      const config = {...dbConfig,
+        poolMin           : 1,
+        poolMax           : 1,
+        poolIncrement     : 0,
+        queueMax          : -2
+      };
+      await assert.rejects(
+        async () => await oracledb.createPool(config),
+        /NJS-007:/
+      );
+    });
+
+    it('2.8.8 queueMax range check, queueMax -0.5 not an integer', async function() {
+      const config = {...dbConfig,
+        poolMin           : 1,
+        poolMax           : 1,
+        poolIncrement     : 0,
+        queueMax          : -1.5
+      };
+      await assert.rejects(
+        async () => await oracledb.createPool(config),
+        /NJS-007:/
+      );
+    });
+
   });
 
   describe('2.9 _enableStats & _logStats functionality', function() {