Make it easier to test external authentication with wallets

Author: Christopher Jones

test/README.md

@@ -75,16 +75,15 @@ vi <some-directory>/node-oracledb/test/dbconfig.js
 module.exports = {
   user          : process.env.NODE_ORACLEDB_USER || "hr",
   password      : process.env.NODE_ORACLEDB_PASSWORD || "welcome",
-  connectString : process.env.NODE_ORACLEDB_CONNECTIONSTRING || "localhost/orcl",
-  externalAuth  : process.env.NODE_ORACLEDB_EXTERNALAUTH ? true : false
+  connectString : process.env.NODE_ORACLEDB_CONNECTIONSTRING || "localhost/orcl"
 };
 ```
 
-To use external authentication, set the `externalAuth` property to
-`true`.  Also make sure Oracle Database and the authentication service
-have been appropriately configured.  See
+To enable external authentication tests, please make sure Oracle Database
+and the authentication service have been appropriately configured.  See
 [Documentation for External Authentication](https://github.com/oracle/node-oracledb/blob/master/doc/api.md#extauth)
-for more details.
+for more details. And then, set the environment variable `NODE_ORACLEDB_EXTERNALAUTH`
+to be `true`.
 
 Note: the test suite requires a schema with these privileges:
 

test/dbconfig.js

@@ -30,15 +30,8 @@
  *
  *****************************************************************************/
 
-if (process.env.NODE_ORACLEDB_EXTERNALAUTH)
-{
-  exports.externalAuth = true;
-}
-else
-{
-  exports.externalAuth = false;
-  exports.user         = process.env.NODE_ORACLEDB_USER || "hr";
-  exports.password     = process.env.NODE_ORACLEDB_PASSWORD || "welcome";
-}
-
-exports.connectString  = process.env.NODE_ORACLEDB_CONNECTIONSTRING || "localhost/orcl";
+module.exports = {
+  user          : process.env.NODE_ORACLEDB_USER || "hr",
+  password      : process.env.NODE_ORACLEDB_PASSWORD || "welcome",
+  connectString : process.env.NODE_ORACLEDB_CONNECTIONSTRING || "localhost/orcl"
+};

test/externalAuth.js

@@ -238,10 +238,10 @@ describe('5. externalAuth.js', function() {
 
   }); // 5.1
 
-  describe.skip('5.2 tests only work when externalAuth is configured on DB', function() {
+  describe('5.2 tests only work when externalAuth is configured on DB', function() {
 
     // need to skip these tests if external authentication is not configured
-    var it = (dbConfig.externalAuth) ? global.it : global.it.skip;
+    var it = (process.env.NODE_ORACLEDB_EXTERNALAUTH) ? global.it : global.it.skip;
 
     it("5.2.1 can get connection from oracledb with external authentication", function(done) {
 

test/list.txt

@@ -134,9 +134,9 @@ Overview of node-oracledb functional tests
         5.1.8 throws error when getting pool from oracledb only given password when externalAuth is enabled
     5.2 tests only work when externalAuth is configured on DB
         5.2.1 can get connection from oracledb with external authentication
-      - 5.2.2 can get pool from oracledb with external authentication
+        5.2.2 can get pool from oracledb with external authentication
         5.2.3 gets multiple connections from oracledb
-      - 5.2.4 gets multiple pools from oracledb
+        5.2.4 gets multiple pools from oracledb
 
 6. dmlReturning.js
     6.1 NUMBER & STRING driver data type