Raise error when subscription notification callback is missing

Author: Christopher Jones

src/njsConnection.cpp

@@ -1433,8 +1433,9 @@ bool njsConnection::ProcessSubscriptionOptions(Local<Object> options,
         Local<Function> callback;
         if (!baton->GetFunctionFromJSON(options, "callback", 1, &callback))
             return false;
-        if (!callback.IsEmpty())
-            baton->subscription->SetCallback(callback);
+        if (callback.IsEmpty())
+            baton->error = njsMessages::Get(errMissingSubscrCallback);
+        else baton->subscription->SetCallback(callback);
     }
 
     // get options that are used for registering queries

src/njsMessages.cpp

@@ -90,6 +90,7 @@ static const char *errMsg[] = {
     "NJS-059: type must be specified for bind position %u", // errMissingTypeByPos
     "NJS-060: type must be specified for bind \"%s\"", // errMissingTypeByName
     "NJS-061: invalid subscription", // errInvalidSubscription
+    "NJS-062: subscription notification callback missing", // errMissingSubscrCallback
 };
 
 

src/njsMessages.h

@@ -93,6 +93,7 @@ typedef enum {
     errMissingTypeByPos,
     errMissingTypeByName,
     errInvalidSubscription,
+    errMissingSubscrCallback,
 
     // New ones should be added here