Update tests for LOB bind enhancement

Author: Christopher Jones

test/list.txt

@@ -1226,7 +1226,7 @@ Overview of node-oracledb functional tests
         71.1.6 BIND_OUT, PL/SQL, a txt file
         71.1.7 BIND_INOUT, PL/SQL, A String. IN LOB gets closed automatically.
         71.1.8 BIND_INOUT, PL/SQL, a txt file
-        71.1.9 Negative: BIND_INOUT, PL/SQL, String as bind IN Value
+        71.1.9 BIND_INOUT, PL/SQL, a String as the bind IN Value
     71.2 persistent BLOB
         71.2.1 BIND_IN, DML, a Buffer value
         71.2.2 BIND_IN, DML, null
@@ -1236,7 +1236,7 @@ Overview of node-oracledb functional tests
         71.2.6 BIND_OUT, PL/SQL, a jpg file
         71.2.7 BIND_INOUT, PL/SQL, a Buffer value
         71.2.8 BIND_INOUT, PL/SQL, a jpg file
-        71.2.9 Negative: BIND_INOUT, PL/SQL, Buffer as bind IN value
+        71.2.9 BIND_INOUT, PL/SQL, a Buffer as the bind IN value
 
 72. lobBind2.js
     72.1 CLOB

test/lobBind1.js

@@ -792,11 +792,11 @@ describe('71. lobBind1.js', function() {
 
     }); // 71.1.8
 
-    it('71.1.9 Negative: BIND_INOUT, PL/SQL, String as bind IN Value', function(done) {
+    it('71.1.9 BIND_INOUT, PL/SQL, a String as the bind IN Value', function(done) {
 
       var seq = 9;
-      var inStr = "I love the sunshine today!",
-        outStr = "A new day has come.";
+      var inStr = "I love the sunshine today!";
+      var outStr = "A new day has come.";
 
       var proc = "CREATE OR REPLACE PROCEDURE nodb_proc_clob_inout3 \n" +
                  "  (p_num IN NUMBER, p_inout IN OUT CLOB) \n" +
@@ -820,11 +820,26 @@ describe('71. lobBind1.js', function() {
               io: { val: inStr, type: oracledb.CLOB, dir: oracledb.BIND_INOUT }
             },
             { autoCommit: true },
-            function(err) {
-              should.exist(err);
-              // NJS-011: encountered bind value and type mismatch in parameter 2
-              (err.message).should.startWith('NJS-011:');
-              cb();
+            function(err, result) {
+              should.not.exist(err);
+              should.exist(result);
+              var lobout = result.outBinds.io;
+
+              lobout.setEncoding("utf8");
+              var clobData = '';
+
+              lobout.on('data', function(chunk) {
+                clobData += chunk;
+              });
+
+              lobout.on('error',function(err) {
+                should.not.exist(err, "lob.on 'error' event!");
+              });
+
+              lobout.on('end', function() {
+                should.strictEqual(clobData, outStr);
+                return cb();
+              });
             }
           );
         },
@@ -1541,7 +1556,7 @@ describe('71. lobBind1.js', function() {
 
     }); // 71.2.8
 
-    it('71.2.9 Negative: BIND_INOUT, PL/SQL, Buffer as bind IN value', function(done) {
+    it('71.2.9 BIND_INOUT, PL/SQL, a Buffer as the bind IN value', function(done) {
 
       var seq = 9;
       var inBuf  = assist.createBuffer(10);
@@ -1573,12 +1588,32 @@ describe('71. lobBind1.js', function() {
             sql,
             bindvar,
             { autoCommit: true },
-            function(err) {
-              should.exist(err);
-              (err.message).should.startWith('NJS-011:');
-              // NJS-011: encountered bind value and type mismatch in parameter 2
+            function(err, result) {
+              should.not.exist(err);
+              should.exist(result);
+              var lob = result.outBinds.io;
+              should.exist(lob);
+
+              var blobData, totalLength = 0;
+              blobData = node6plus ? Buffer.alloc(0) : new Buffer(0);
+
+              lob.on('data', function(chunk) {
+                totalLength = totalLength + chunk.length;
+                blobData = Buffer.concat([blobData, chunk], totalLength);
+              });
+
+              lob.on('error', function(err) {
+                should.not.exist(err, "lob.on 'error' event.");
+              });
+
+              lob.on('end', function() {
+                fs.readFile(jpgFileName, function(err, originalData) {
+                  should.not.exist(err);
+                  should.strictEqual(totalLength, originalData.length);
+                  return cb();
+                });
+              });
 
-              cb();
             }
           );
         },