Skip to content

Commit e7e2d11

Browse files
committed
Enable tests on Windows
1 parent 26926ff commit e7e2d11

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
runs-on: ${{ matrix.os }}
105105
strategy:
106106
matrix:
107-
os: [ubuntu-latest, macos-latest] # TODO: windows-latest
107+
os: [ubuntu-latest, macos-latest, windows-latest]
108108
test_name: [ test_jbang_integration.py, test_maven_plugin.py, test_gradle_plugin.py ]
109109
include:
110110
# We need to skip native-image tests on Gradle and MacOS runners: it seems that with
@@ -176,6 +176,14 @@ jobs:
176176
run: choco install jbang
177177
shell: pwsh
178178

179+
# - name: Setup MSVC on Windows
180+
# if: runner.os == 'Windows'
181+
# uses: ilammy/msvc-dev-cmd@v1
182+
183+
- name: Add git utils to $PATH on Windows
184+
if: runner.os == 'Windows'
185+
run: echo "C:\Program Files\Git\usr\bin" >> $env:GITHUB_PATH
186+
179187
- name: Run integration tests
180188
run: |
181189
mvn --batch-mode -s settings.xml -Dgradle.java.home=$GRADLE_JAVA_HOME exec:java@integration-tests -Dintegration.tests.args="${{ matrix.test_name }} ${{ matrix.extra_test_args }} $TEST_FLAGS"
@@ -193,11 +201,13 @@ jobs:
193201
runs-on: ${{ matrix.os }}
194202
strategy:
195203
matrix:
196-
os: [ubuntu-latest, macos-latest] # TODO: windows-latest
204+
os: [ubuntu-latest, macos-latest, windows-latest]
197205
tests: [unit-cp, unit-mp, unit-it-mp, isolate-it]
198-
exclude: # TODO: find out why the resources are not in the bundle (the same for Windows)
206+
exclude: # TODO: isolate resources seem to not be in the bundle for those
199207
- os: macos-latest
200208
tests: isolate-it
209+
- os: windows-latest
210+
tests: isolate-it
201211
include:
202212
- tests: unit-cp
203213
maven_args: "test"

0 commit comments

Comments
 (0)