Enforcing styling through Travis and pep8 (#59)

Author: aliabbasrizvi

.travis.yml

@@ -3,6 +3,7 @@ python:
   - "2.7"
   - "3.4"
 install: "pip install -r requirements/core.txt;pip install -r requirements/test.txt"
+before_script: "pep8"
 script: "nosetests --with-coverage --cover-package=optimizely"
 after_success:
   - coveralls

CONTRIBUTING.md

@@ -21,7 +21,7 @@ We welcome contributions and feedback! All contributors must sign our [Contribut
 
 ## Style
 
-We enforce PEP-8 rules with a few minor deviations.
+We enforce PEP-8 rules with a few minor [deviations](https://github.com/optimizely/python-sdk/blob/master/tox.ini).
 
 ## License
 

optimizely/entities.py

@@ -11,6 +11,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+
 class BaseEntity(object):
 
   def __eq__(self, other):

optimizely/error_handler.py

@@ -11,6 +11,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+
 class BaseErrorHandler(object):
   """ Class encapsulating exception handling functionality.
   Override with your own exception handler providing handle_error method. """

optimizely/exceptions.py

@@ -11,6 +11,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+
 class InvalidAttributeException(Exception):
   """ Raised when provided attribute is invalid. """
   pass

optimizely/helpers/validator.py

@@ -136,10 +136,10 @@ def is_user_profile_valid(user_profile):
   if not type(user_profile) is dict:
     return False
 
-  if not UserProfile.USER_ID_KEY in user_profile:
+  if UserProfile.USER_ID_KEY not in user_profile:
     return False
 
-  if not UserProfile.EXPERIMENT_BUCKET_MAP_KEY in user_profile:
+  if UserProfile.EXPERIMENT_BUCKET_MAP_KEY not in user_profile:
     return False
 
   experiment_bucket_map = user_profile.get(UserProfile.EXPERIMENT_BUCKET_MAP_KEY)

optimizely/optimizely.py

@@ -192,7 +192,7 @@ def activate(self, experiment_key, user_id, attributes=None):
 
     return variation.key
 
-  def track(self, event_key, user_id,  attributes=None, event_tags=None):
+  def track(self, event_key, user_id, attributes=None, event_tags=None):
     """ Send conversion event to Optimizely.
 
     Args:

optimizely/user_profile.py

@@ -2,7 +2,7 @@
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-# 
+#
 # http://www.apache.org/licenses/LICENSE-2.0
 
 # Unless required by applicable law or agreed to in writing, software

tests/benchmarking/benchmarking_tests.py

@@ -169,7 +169,7 @@ def compute_average(values):
   Returns:
     Average of all values.
   """
-  return float(sum(values))/len(values)
+  return float(sum(values)) / len(values)
 
 
 def compute_median(values):
@@ -185,7 +185,7 @@ def compute_median(values):
   sorted_values = sorted(values)
   num1 = (len(values) - 1) / 2
   num2 = len(values) / 2
-  return float(sorted_values[num1] + sorted_values[num2])/2
+  return float(sorted_values[num1] + sorted_values[num2]) / 2
 
 
 def display_results(results_average, results_median):

tests/helpers_tests/test_event_tag_utils.py

@@ -17,6 +17,7 @@
 
 from optimizely.helpers import event_tag_utils
 
+
 class EventTagUtilsTest(unittest.TestCase):
 
   def test_get_revenue_value__invalid_args(self):