fix(set-forced-variation): Treats empty variation key as invalid and does not reset variation. (#113)

Author: mfahadahmed

OptimizelySDK.Tests/ProjectConfigTest.cs

@@ -778,7 +778,7 @@ public void TestSetForcedVariationWithInvalidVariationKey()
             var experimentKey = "test_experiment";
 
             Assert.False(Config.SetForcedVariation(experimentKey, userId, "variation_not_in_datafile"));
-            Assert.True(Config.SetForcedVariation(experimentKey, userId, ""));
+            Assert.False(Config.SetForcedVariation(experimentKey, userId, ""));
             Assert.True(Config.SetForcedVariation(experimentKey, userId, null));
         }
 

OptimizelySDK/ProjectConfig.cs

@@ -526,14 +526,21 @@ public bool SetForcedVariation(string experimentKey, string userId, string varia
                 return false;
             }
 
+            // Empty variation key is invalid.
+            if (variationKey != null && variationKey.Length == 0)
+            {
+                Logger.Log(LogLevel.DEBUG, "Variation key is invalid.");
+                return false;
+            }
+
             var experimentId = GetExperimentFromKey(experimentKey).Id;
 
             // this case is logged in getExperimentFromKey
             if (string.IsNullOrEmpty(experimentId))
                 return false;
 
             // clear the forced variation if the variation key is null
-            if (string.IsNullOrEmpty(variationKey))
+            if (variationKey == null)
             {
                 if (_ForcedVariationMap.ContainsKey(userId) && _ForcedVariationMap[userId].ContainsKey(experimentId))
                     _ForcedVariationMap[userId].Remove(experimentId);