Handle errors so apps don't crash (#126)

* Try-catch errors when building OptimizelyClient

Summary:

Test Plan:

Reviewers:

Subscribers:

JIRA Issues:

* Try-catch errors when building OptimizelyClient

Summary: Try-catch errors when building OptimizelyClient

Test Plan: tests

Reviewers: #oasis_team_review

JIRA Issues: OASIS-1516

Differential Revision: https://phabricator.optimizely.com/D16771

Author: elliotykim

android-sdk/src/androidTest/java/com/optimizely/ab/android/sdk/OptimizelyManagerTest.java

@@ -28,14 +28,13 @@
 import android.support.test.runner.AndroidJUnit4;
 
 import com.optimizely.ab.android.datafile_handler.DatafileHandler;
-import com.optimizely.ab.android.datafile_handler.DefaultDatafileHandler;
 import com.optimizely.ab.android.datafile_handler.DatafileService;
+import com.optimizely.ab.android.datafile_handler.DefaultDatafileHandler;
 import com.optimizely.ab.android.event_handler.DefaultEventHandler;
 import com.optimizely.ab.android.shared.ServiceScheduler;
 import com.optimizely.ab.android.user_profile.DefaultUserProfileService;
-import com.optimizely.ab.config.parser.ConfigParseException;
-
 import com.optimizely.ab.bucketing.UserProfileService;
+import com.optimizely.ab.config.parser.ConfigParseException;
 import com.optimizely.ab.event.EventHandler;
 
 import org.junit.Before;
@@ -250,7 +249,7 @@ public void injectOptimizelyHandlesInvalidDatafile() {
             fail("Timed out");
         }
 
-        verify(logger).error(eq("Unable to build optimizely instance"), any(Exception.class));
+        verify(logger).error(eq("Unable to build OptimizelyClient instance"), any(Exception.class));
 
     }
 

android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyManager.java

@@ -31,17 +31,16 @@
 
 import com.optimizely.ab.Optimizely;
 import com.optimizely.ab.android.datafile_handler.DatafileHandler;
-import com.optimizely.ab.android.datafile_handler.DefaultDatafileHandler;
 import com.optimizely.ab.android.datafile_handler.DatafileLoadedListener;
 import com.optimizely.ab.android.datafile_handler.DatafileService;
-import com.optimizely.ab.android.event_handler.EventIntentService;
+import com.optimizely.ab.android.datafile_handler.DefaultDatafileHandler;
 import com.optimizely.ab.android.event_handler.DefaultEventHandler;
+import com.optimizely.ab.android.event_handler.EventIntentService;
 import com.optimizely.ab.android.user_profile.DefaultUserProfileService;
 import com.optimizely.ab.bucketing.UserProfileService;
 import com.optimizely.ab.config.parser.ConfigParseException;
 import com.optimizely.ab.error.ErrorHandler;
 import com.optimizely.ab.event.EventHandler;
-import com.optimizely.ab.event.internal.EventBuilder;
 import com.optimizely.ab.event.internal.payload.Event;
 
 import org.slf4j.Logger;
@@ -134,6 +133,8 @@ public OptimizelyClient initialize(@NonNull Context context, @NonNull String dat
             logger.error("Unable to parse compiled data file", e);
         } catch (Exception e) {
             logger.error("Unable to build OptimizelyClient instance", e);
+        } catch (Error e) {
+            logger.error("Unable to build OptimizelyClient instance", e);
         }
 
         datafileHandler.downloadDatafile(context, projectId, null);
@@ -360,7 +361,9 @@ public void onStartComplete(UserProfileService userProfileService) {
                 }
             }
         } catch (Exception e) {
-            logger.error("Unable to build optimizely instance", e);
+            logger.error("Unable to build OptimizelyClient instance", e);
+        } catch (Error e) {
+            logger.error("Unable to build OptimizelyClient instance", e);
         }
     }