-
Notifications
You must be signed in to change notification settings - Fork 49
Implementation of altair backend.
#654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
The failing tests are still due to ERROR: Could not install packages due to an OSError: [Errno 28] No space left on deviceLooks like In a fresh environment without |
|
Great investigative work! Have you tried adding the conda-forge version |
|
Great! Adding The two tests failing currently are unrelated but they seem to persist even after multiple re-runs. One of them is due to comparison of positive zero with negative zero similar to #642. The other one is due to the actual not being close enough to the expected. I'm not entirely sure what causes this. |
|
Yes, please open another PR to fix this. We will see whether the two mentioned issues persist there. Thanks! |
timmens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, the only issue I see is that the altair plot is not rendered in the documentation.
Could you check whether its possible to render the chart as a static image (png or svg) for the docs? I believe you must add a dependency to the rtd_environment in this case.
Thanks!
Summary of Changes
line_plotandgrid_line_plotfunction for altair.Plot Comparision
Checklist