revert while logic, just like ngx.pipe

Author: chronolaw

lib/resty/core/socket.lua

@@ -220,49 +220,43 @@ local function sslhandshake(cosocket, reused_session, server_name, ssl_verify,
         error("no request ctx found", 2)
     end
 
-    if rc == FFI_ERROR then
-        goto failed
-    end
+    while true do
+        if rc == FFI_ERROR then
+            if openssl_error_code[0] ~= 0 then
+                return nil, openssl_error_code[0] .. ": " .. ffi_str(errmsg[0])
+            end
 
-    if rc == FFI_DONE then
-        return reused_session
-    end
+            return nil, ffi_str(errmsg[0])
+        end
 
-    if rc == FFI_OK and reused_session == false then
-        return true
-    end
+        if rc == FFI_DONE then
+            return reused_session
+        end
 
-    if rc == FFI_AGAIN then
-        co_yield()
-    end
+        if rc == FFI_OK then
+            if reused_session == false then
+                return true
+            end
 
-    -- (rc == FFI_OK and reused_session ~= false) or
-    -- (rc == FFI_AGAIN and reused_session == cdata/false then co_yield)
+            rc = C.ngx_http_lua_ffi_socket_tcp_get_sslhandshake_result(r, u,
+                     session_ptr, errmsg, openssl_error_code)
 
-    rc = C.ngx_http_lua_ffi_socket_tcp_get_sslhandshake_result(r, u,
-            session_ptr, errmsg, openssl_error_code)
+            assert(rc == FFI_OK)
 
-    if rc == FFI_OK then
-        if reused_session == false then
-            return true
-        end
+            if session_ptr[0] == nil then
+                return session_ptr[0]
+            end
 
-        if session_ptr[0] == nil then
-            return session_ptr[0]
+            return ffi_gc(session_ptr[0], C.ngx_http_lua_ffi_ssl_free_session)
         end
 
-        return ffi_gc(session_ptr[0], C.ngx_http_lua_ffi_ssl_free_session)
-    end
-
-::failed::
+        assert(rc == FFI_AGAIN)
 
-    assert(rc == FFI_ERROR)
+        co_yield()
 
-    if openssl_error_code[0] ~= 0 then
-        return nil, openssl_error_code[0] .. ": " .. ffi_str(errmsg[0])
+        rc = C.ngx_http_lua_ffi_socket_tcp_get_sslhandshake_result(r, u,
+                 session_ptr, errmsg, openssl_error_code)
     end
-
-    return nil, ffi_str(errmsg[0])
 end