refactorying deal with get_sslhandshake_result

Author: chronolaw

lib/resty/core/socket.lua

@@ -228,49 +228,40 @@ local function sslhandshake(cosocket, reused_session, server_name, ssl_verify,
         return reused_session
     end
 
-    if rc == FFI_OK then
-        if reused_session == false then
-            return true
-        end
-
-        rc = C.ngx_http_lua_ffi_socket_tcp_get_sslhandshake_result(r, u,
-                 session_ptr, errmsg, openssl_error_code)
-
-        assert(rc == FFI_OK)
-
-        goto reused_sess
+    if rc == FFI_OK and reused_session == false then
+        return true
     end
 
-    assert(rc == FFI_AGAIN)
+    if rc == FFI_AGAIN then
+        co_yield()
+    end
 
-    co_yield()
+    -- (rc == FFI_OK and reused_session ~= false) or co_yield()
 
     rc = C.ngx_http_lua_ffi_socket_tcp_get_sslhandshake_result(r, u,
-             session_ptr, errmsg, openssl_error_code)
+            session_ptr, errmsg, openssl_error_code)
 
-::failed::
+    if rc == FFI_OK then
+        if reused_session == false then
+            return true
+        end
 
-    if rc == FFI_ERROR then
-        if openssl_error_code[0] ~= 0 then
-            return nil, openssl_error_code[0] .. ": " .. ffi_str(errmsg[0])
+        if session_ptr[0] == nil then
+            return nil
         end
 
-        return nil, ffi_str(errmsg[0])
+        return ffi_gc(session_ptr[0], C.ngx_http_lua_ffi_ssl_free_session)
     end
 
-    assert(rc == FFI_OK)
-
-    if reused_session == false then
-        return true
-    end
+::failed::
 
-::reused_sess::
+    assert(rc == FFI_ERROR)
 
-    if session_ptr[0] == nil then
-        return nil
+    if openssl_error_code[0] ~= 0 then
+        return nil, openssl_error_code[0] .. ": " .. ffi_str(errmsg[0])
     end
 
-    return ffi_gc(session_ptr[0], C.ngx_http_lua_ffi_ssl_free_session)
+    return nil, ffi_str(errmsg[0])
 end