bugfix: the format in argerror messages are incorrect (#1787)

sorc1 · web-flow · commit db1999816e0a · 2020-09-28T16:02:55.000+08:00
lua_pushfstring() doesn't accept '%i' format. We should use '%d'
instead.
diff --git a/src/ngx_http_lua_socket_tcp.c b/src/ngx_http_lua_socket_tcp.c
@@ -901,7 +901,7 @@ ngx_http_lua_socket_tcp_connect(lua_State *L)
             pool_size = (ngx_int_t) lua_tointeger(L, -1);
 
             if (pool_size <= 0) {
-                msg = lua_pushfstring(L, "bad \"pool_size\" option value: %i",
+                msg = lua_pushfstring(L, "bad \"pool_size\" option value: %d",
                                       pool_size);
                 return luaL_argerror(L, n, msg);
             }
@@ -920,7 +920,7 @@ ngx_http_lua_socket_tcp_connect(lua_State *L)
             backlog = (ngx_int_t) lua_tointeger(L, -1);
 
             if (backlog < 0) {
-                msg = lua_pushfstring(L, "bad \"backlog\" option value: %i",
+                msg = lua_pushfstring(L, "bad \"backlog\" option value: %d",
                                       backlog);
                 return luaL_argerror(L, n, msg);
             }
@@ -5286,7 +5286,7 @@ ngx_http_lua_socket_tcp_setkeepalive(lua_State *L)
         }
 
         if (pool_size <= 0) {
-            msg = lua_pushfstring(L, "bad \"pool_size\" option value: %i",
+            msg = lua_pushfstring(L, "bad \"pool_size\" option value: %d",
                                   pool_size);
             return luaL_argerror(L, n, msg);
         }

Original file line number	Diff line number	Diff line change
`@@ -901,7 +901,7 @@ ngx_http_lua_socket_tcp_connect(lua_State *L)`
`901`	`901`	`pool_size = (ngx_int_t) lua_tointeger(L, -1);`
`902`	`902`
`903`	`903`	`if (pool_size <= 0) {`
`904`		`- msg = lua_pushfstring(L, "bad \"pool_size\" option value: %i",`
	`904`	`+ msg = lua_pushfstring(L, "bad \"pool_size\" option value: %d",`
`905`	`905`	`pool_size);`
`906`	`906`	`return luaL_argerror(L, n, msg);`
`907`	`907`	`}`
`@@ -920,7 +920,7 @@ ngx_http_lua_socket_tcp_connect(lua_State *L)`
`920`	`920`	`backlog = (ngx_int_t) lua_tointeger(L, -1);`
`921`	`921`
`922`	`922`	`if (backlog < 0) {`
`923`		`- msg = lua_pushfstring(L, "bad \"backlog\" option value: %i",`
	`923`	`+ msg = lua_pushfstring(L, "bad \"backlog\" option value: %d",`
`924`	`924`	`backlog);`
`925`	`925`	`return luaL_argerror(L, n, msg);`
`926`	`926`	`}`
`@@ -5286,7 +5286,7 @@ ngx_http_lua_socket_tcp_setkeepalive(lua_State *L)`
`5286`	`5286`	`}`
`5287`	`5287`
`5288`	`5288`	`if (pool_size <= 0) {`
`5289`		`- msg = lua_pushfstring(L, "bad \"pool_size\" option value: %i",`
	`5289`	`+ msg = lua_pushfstring(L, "bad \"pool_size\" option value: %d",`
`5290`	`5290`	`pool_size);`
`5291`	`5291`	`return luaL_argerror(L, n, msg);`
`5292`	`5292`	`}`