bugfix: the timeout overflow checks did not work on 32-bit systems.

Author: agentzh

src/ngx_http_lua_socket_tcp.c

@@ -2711,9 +2711,8 @@ ngx_http_lua_socket_tcp_settimeout(lua_State *L)
     }
 
     timeout = (ngx_int_t) lua_tonumber(L, 2);
-    if (timeout > (ngx_int_t) NGX_MAX_INT32_VALUE) {
-        return luaL_error(L, "lua tcp socket timeout %f will overflow",
-                          (lua_Number) timeout);
+    if (timeout >> 31) {
+        return luaL_error(L, "timeout value too large");
     }
 
     lua_pushinteger(L, timeout);
@@ -2759,21 +2758,18 @@ ngx_http_lua_socket_tcp_settimeouts(lua_State *L)
     }
 
     connect_timeout = (ngx_int_t) lua_tonumber(L, 2);
-    if (connect_timeout > (ngx_int_t) NGX_MAX_INT32_VALUE) {
-        return luaL_error(L, "lua tcp socket connect timeout %f will overflow",
-                          (lua_Number) connect_timeout);
+    if (connect_timeout >> 31) {
+        return luaL_error(L, "timeout value too large");
     }
 
     send_timeout = (ngx_int_t) lua_tonumber(L, 3);
-    if (send_timeout > (ngx_int_t) NGX_MAX_INT32_VALUE) {
-        return luaL_error(L, "lua tcp socket send timeout %f will overflow",
-                          (lua_Number) send_timeout);
+    if (send_timeout >> 31) {
+        return luaL_error(L, "timeout value too large");
     }
 
     read_timeout = (ngx_int_t) lua_tonumber(L, 4);
-    if (read_timeout > (ngx_int_t) NGX_MAX_INT32_VALUE) {
-        return luaL_error(L, "lua tcp socket read timeout %f will overflow",
-                          (lua_Number) read_timeout);
+    if (read_timeout >> 31) {
+        return luaL_error(L, "timeout value too large");
     }
 
     lua_rawseti(L, 1, SOCKET_READ_TIMEOUT_INDEX);

t/147-tcp-socket-timeouts.t

@@ -560,7 +560,7 @@ failed to receive a line: closed []
 GET /t
 --- response_body_like
 settimeouts: ok
-failed to set timeouts: lua tcp socket connect timeout 2147483648(?:\.\d+)? will overflow
+failed to set timeouts: timeout value too large
 --- no_error_log
 [error]
 
@@ -591,7 +591,7 @@ failed to set timeouts: lua tcp socket connect timeout 2147483648(?:\.\d+)? will
 GET /t
 --- response_body_like
 settimeouts: ok
-failed to set timeouts: lua tcp socket send timeout 2147483648(?:\.\d+)? will overflow
+failed to set timeouts: timeout value too large
 --- no_error_log
 [error]
 
@@ -622,6 +622,6 @@ failed to set timeouts: lua tcp socket send timeout 2147483648(?:\.\d+)? will ov
 GET /t
 --- response_body_like
 settimeouts: ok
-failed to set timeouts: lua tcp socket read timeout 2147483648(?:\.\d+)? will overflow
+failed to set timeouts: timeout value too large
 --- no_error_log
 [error]