Skip to content

Commit 7e5a993

Browse files
committed
change test case for setclientcert
1 parent 7ba799d commit 7e5a993

File tree

1 file changed

+28
-16
lines changed

1 file changed

+28
-16
lines changed

t/162-socket-tls-handshake.t

Lines changed: 28 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -261,16 +261,19 @@ hello, CN=foo@example.com,O=OpenResty,ST=California,C=US
261261
content_by_lua_block {
262262
local sock = ngx.socket.tcp()
263263

264-
sock:setclientcert("doesnt", "work")
264+
local ok, err = sock:setclientcert("doesnt", "work")
265+
if not ok then
266+
ngx.say('failed to setclientcert: ', err)
267+
return
268+
end
265269

266270
assert(sock:close())
267271
}
268272
}
269273
--- request
270274
GET /t
271-
--- error_code: 500
272-
--- error_log eval
273-
qr/\[error\] .* bad client cert type/
275+
--- response_body
276+
failed to setclientcert: bad client cert type
274277
--- no_error_log
275278
[alert]
276279
[crit]
@@ -293,7 +296,11 @@ qr/\[error\] .* bad client cert type/
293296
294297
local chain = assert(ssl.parse_pem_cert(cert_data))
295298
296-
sock:setclientcert(chain, 'work')
299+
local ok, err = sock:setclientcert(chain, 'work')
300+
if not ok then
301+
ngx.say('failed to setclientcert: ', err)
302+
return
303+
end
297304
298305
assert(sock:close())
299306
}
@@ -302,9 +309,8 @@ qr/\[error\] .* bad client cert type/
302309
--- user_files eval: $::mtls_user_files
303310
--- request
304311
GET /t
305-
--- error_code: 500
306-
--- error_log eval
307-
qr/\[error\] .* bad client pkey type/
312+
--- response_body
313+
failed to setclientcert: bad client pkey type
308314
--- no_error_log
309315
[alert]
310316
[crit]
@@ -318,16 +324,19 @@ qr/\[error\] .* bad client pkey type/
318324
content_by_lua_block {
319325
local sock = ngx.socket.tcp()
320326

321-
sock:setclientcert(nil, "work")
327+
local ok, err = sock:setclientcert(nil, "work")
328+
if not ok then
329+
ngx.say('failed to setclientcert: ', err)
330+
return
331+
end
322332

323333
assert(sock:close())
324334
}
325335
}
326336
--- request
327337
GET /t
328-
--- error_code: 500
329-
--- error_log eval
330-
qr/\[error\] .* client certificate must be supplied with corresponding private key/
338+
--- response_body
339+
failed to setclientcert: client certificate must be supplied with corresponding private key
331340
--- no_error_log
332341
[alert]
333342
[crit]
@@ -341,16 +350,19 @@ qr/\[error\] .* client certificate must be supplied with corresponding private k
341350
content_by_lua_block {
342351
local sock = ngx.socket.tcp()
343352

344-
sock:setclientcert('doesnt', nil)
353+
local ok, err = sock:setclientcert('doesnt', nil)
354+
if not ok then
355+
ngx.say('failed to setclientcert: ', err)
356+
return
357+
end
345358

346359
assert(sock:close())
347360
}
348361
}
349362
--- request
350363
GET /t
351-
--- error_code: 500
352-
--- error_log eval
353-
qr/\[error\] .* client certificate must be supplied with corresponding private key/
364+
--- response_body
365+
failed to setclientcert: client certificate must be supplied with corresponding private key
354366
--- no_error_log
355367
[alert]
356368
[crit]

0 commit comments

Comments
 (0)