Skip to content

Commit ec8217c

Browse files
committed
Correct MaxTE calculation
1 parent a432acf commit ec8217c

File tree

1 file changed

+4
-3
lines changed
  • Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/PowerTransmissions

1 file changed

+4
-3
lines changed

Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/PowerTransmissions/GearBox.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ public float TractiveForceN
657657
// During normal operation fuel admission is fixed, and therefore TE follows curve as RpM varies
658658
tractiveForceN = torqueCurveMultiplier * DieselEngine.DieselTorqueTab[DieselEngine.RealRPM] / DieselEngine.DieselTorqueTab.MaxY() * CurrentGear.MaxTractiveForceN;
659659

660-
// Trace.TraceInformation("Tractive Force - TF {0} tcm {1} RpM {2} Torque@RpM {3} TorqueMax {4} MaxTE {5}", tractiveForceN, torqueCurveMultiplier, DieselEngine.RealRPM, DieselEngine.DieselTorqueTab[DieselEngine.RealRPM], DieselEngine.DieselTorqueTab.MaxY(), CurrentGear.MaxTractiveForceN);
660+
// Trace.TraceInformation("Tractive Force - CarID {0} Gear {1}, TF {2:N1} lbf, tcm {3:N1}, RpM {4}, Torque@RpM {5}, TorqueMax {6}, MaxTE {7:N1} DieselOutputHp {8:N1} hp", Locomotive.CarID, GearIndication, 0.224809f * tractiveForceN, torqueCurveMultiplier, DieselEngine.RealRPM, DieselEngine.DieselTorqueTab[DieselEngine.RealRPM], DieselEngine.DieselTorqueTab.MaxY(), 0.224809f * CurrentGear.MaxTractiveForceN, 0.00134102f * DieselEngine.CurrentDieselOutputPowerW);
661661

662662
Locomotive.HuDGearMaximumTractiveForce = CurrentGear.MaxTractiveForceN;
663663

@@ -809,7 +809,8 @@ public void Initialize()
809809
else
810810
{
811811
// if they entered the TE at maximum gear speed, then increase the value accordingly
812-
Gears[i].MaxTractiveForceN = GearBoxParams.GearBoxTractiveForceAtSpeedN[i] * DieselEngine.DieselTorqueTab.MaxY() / DieselEngine.DieselTorqueTab[DieselEngine.RealRPM];
812+
Gears[i].MaxTractiveForceN = GearBoxParams.GearBoxTractiveForceAtSpeedN[i] * DieselEngine.DieselTorqueTab.MaxY() / DieselEngine.DieselTorqueTab[DieselEngine.MaxRPM];
813+
// Trace.TraceInformation("MaxTractiveForce - CarID {0} MaxTE {1} ")
813814
}
814815
// For purposes of calculating engine efficiency the tractive force at maximum gear speed needs to be used.
815816
if (GearBoxParams.GearBoxTractiveForceAtSpeedN[i] != 0)
@@ -820,7 +821,7 @@ public void Initialize()
820821
else
821822
{
822823
// Assume that user entered max TE at maximum torque point
823-
Gears[i].TractiveForceatMaxSpeedN = GearBoxParams.GearBoxMaxTractiveForceForGearsN[i] / (DieselEngine.DieselTorqueTab.MaxY() / DieselEngine.DieselTorqueTab[DieselEngine.RealRPM]);
824+
Gears[i].TractiveForceatMaxSpeedN = GearBoxParams.GearBoxMaxTractiveForceForGearsN[i] / (DieselEngine.DieselTorqueTab.MaxY() / DieselEngine.DieselTorqueTab[DieselEngine.MaxRPM]);
824825
}
825826

826827
Gears[i].OverspeedPercentage = GearBoxParams.GearBoxOverspeedPercentageForFailure;

0 commit comments

Comments
 (0)