No train path cloning at route pre-precess phase

Author: pzgulyas

Source/Orts.Simulation/Simulation/Timetables/ProcessTimetable.cs

@@ -1160,7 +1160,7 @@ public bool PreProcessRoutes(CancellationToken cancellation)
             {
                 // read route
                 bool pathValid = true;
-                AIPath newPath = LoadPath(thisRoute, out pathValid);
+                LoadPathNoClone(thisRoute, out pathValid);
                 if (!pathValid) allPathsLoaded = false;
                 if (cancellation.IsCancellationRequested)
                     return (false);
@@ -1176,7 +1176,8 @@ public bool PreProcessRoutes(CancellationToken cancellation)
         /// <param name="pathstring"></param>
         /// <param name="validPath"></param>
         /// <returns></returns>
-        public AIPath LoadPath(string pathstring, out bool validPath)
+        public AIPath LoadPath(string pathstring, out bool validPath) => new AIPath(LoadPathNoClone(pathstring, out validPath));
+        public AIPath LoadPathNoClone(string pathstring, out bool validPath)
         {
             validPath = true;
 
@@ -1191,11 +1192,7 @@ public AIPath LoadPath(string pathstring, out bool validPath)
             bool binaryloaded = false;
             AIPath outPath = null;
 
-            if (Paths.ContainsKey(formedpathFilefull))
-            {
-                outPath = new AIPath(Paths[formedpathFilefull]);
-            }
-            else
+            if (!Paths.TryGetValue(formedpathFilefull, out outPath))
             {
                 string formedpathFilefullBinary = Path.Combine(Path.GetDirectoryName(formedpathFilefull), "OpenRails");
                 formedpathFilefullBinary = Path.Combine(formedpathFilefullBinary, Path.GetFileNameWithoutExtension(formedpathFilefull));
@@ -1213,7 +1210,7 @@ public AIPath LoadPath(string pathstring, out bool validPath)
 
                             if (outPath.Nodes != null)
                             {
-                                Paths.Add(formedpathFilefull, new AIPath(outPath));
+                                Paths.Add(formedpathFilefull, outPath);
                                 binaryloaded = true;
                             }
                         }
@@ -1235,7 +1232,7 @@ public AIPath LoadPath(string pathstring, out bool validPath)
                         {
                             try
                             {
-                                Paths.Add(formedpathFilefull, new AIPath(outPath));
+                                Paths.Add(formedpathFilefull, outPath);
                             }
                             catch (Exception e)
                             {