Replaced the option OutOfFocus" with check on option SuppressConfirmations

Author: sweiland-openrails

Source/Documentation/Manual/images/options-system.png

@@ -408,7 +408,7 @@ The default setting is checked.
 
 
 At game start, Electric - power connected
------------------------------------------
+-----------------------------------
 
 When this option is checked, stationary electric locos start the simulation with power available.
 Uncheck this option for a more detailed behaviour in which the player has to switch on electrical equipment.
@@ -602,15 +602,6 @@ specific width and height to be used.
 
 The format is <width>x<height>, for example 1024x768.
 
-.. -options-out-of-focus:
-
-Notify out of focus
--------------------
-
-When this option is checked, on the corners of the Open Rails main window a red rectangle is shown when the window is not in focus.
-Just a reminder that the main window currently does not react on keystrokes.
-
-The default setting is unchecked.
 
 .. _options-window-glass:
 

Source/Documentation/Manual/options.rst

@@ -303,7 +303,6 @@ orderby folder.Key
 
             checkWindowed.Checked = !Settings.FullScreen;
             comboWindowSize.Text = Settings.WindowSize;
-            checkOutOfFocus.Checked = Settings.OutOfFocus;
             checkWindowGlass.Checked = Settings.WindowGlass;
 
             // keep values in line with enum Orts.Simulation.ConfirmLevel
@@ -508,7 +507,6 @@ void buttonOK_Click(object sender, EventArgs e)
                     UpdateManager.SetChannel((string)control.Tag);
             Settings.FullScreen = !checkWindowed.Checked;
             Settings.WindowSize = GetValidWindowSize(comboWindowSize.Text);
-            Settings.OutOfFocus = checkOutOfFocus.Checked;
             Settings.WindowGlass = checkWindowGlass.Checked;
             Settings.SuppressConfirmations = comboControlConfirmations.SelectedIndex;
             Settings.WebServerPort = (int)numericWebServerPort.Value;
@@ -892,7 +890,6 @@ private void InitializeHelpIcons()
                 (pbLanguage, new Control[] { labelLanguage, comboLanguage }),
                 (pbUpdateMode, new Control[] { labelUpdateMode }),
                 (pbWindowed, new Control[] { checkWindowed, labelWindowSize, comboWindowSize }),
-                (pbOutOfFocus, new[] { checkOutOfFocus }),
                 (pbWindowGlass, new[] { checkWindowGlass }),
                 (pbControlConfirmations, new Control[] { labelControlConfirmations, comboControlConfirmations }),
                 (pbWebServerPort, new Control[] { labelWebServerPort }),
@@ -1039,10 +1036,6 @@ private void HelpIcon_Click(object sender, EventArgs _)
                     pbWindowed,
                     baseUrl + "/options.html#windowed"
                 },
-                {
-                    pbOutOfFocus,
-                    baseUrl + "/options.html#out-of-focus"
-                },
                 {
                     pbWindowGlass,
                     baseUrl + "/options.html#window-glass"

Source/Menu/Options.Designer.cs

@@ -277,8 +277,6 @@ public enum DirectXFeature
         public bool FullScreen { get; set; }
         [Default("1024x768")]
         public string WindowSize { get; set; }
-        [Default(true)]
-        public bool OutOfFocus { get; set; }
         [Default(false)]
         public bool WindowGlass { get; set; }
         [Default(0)]

Source/Menu/Options.cs

@@ -504,7 +504,9 @@ internal void Initialize()
             TrainListWindow = new TrainListWindow(WindowManager);
             TTDetachWindow = new TTDetachWindow(WindowManager);
             EOTListWindow = new EOTListWindow(WindowManager);
-            if (Settings.OutOfFocus)
+            if (Settings.SuppressConfirmations < (int)ConfirmLevel.Error)
+                // confirm level Error might be set to suppressed when taking a movie
+                // do not show the out of focus red square in that case
                 OutOfFocusWindow = new OutOfFocusWindow(WindowManager);
             WindowManager.Initialize();
 
@@ -859,7 +861,9 @@ public void Update(RenderFrame frame, float elapsedRealTime)
             // TODO: This is not correct. The ActivityWindow's PrepareFrame is already called by the WindowManager!
             if (Simulator.ActivityRun != null) ActivityWindow.PrepareFrame(elapsedTime, true);
 
-            if (Settings.OutOfFocus)
+            if (Settings.SuppressConfirmations < (int)ConfirmLevel.Error)
+                // confirm level Error might be set to suppressed when taking a movie
+                // do not show the out of focus red square in that case 
                 OutOfFocusWindow.Visible = !this.Game.IsActive;
 
             WindowManager.PrepareFrame(frame, elapsedTime);