Check on installing/setting route in OR progranm directory one piece of code

Author: sweiland-openrails

Source/Menu/DownloadContentForm.cs

@@ -204,10 +204,7 @@ private async void DownloadContentButton_Click(object sender, EventArgs e)
             string topPathDirectoryExe = determineTopDirectory(pathDirectoryExe.Substring(6));
             string topInstallPath = determineTopDirectory(installPath);
 
-            if (topPathDirectoryExe.Equals(topInstallPath, StringComparison.OrdinalIgnoreCase))
-            {
-                message = Catalog.GetStringFmt("Top directory {0} is the same for exe and route, installing in this directory not allowed", topInstallPath);
-                MessageBox.Show(message, Catalog.GetString("Attention"), MessageBoxButtons.OK, MessageBoxIcon.Error);
+            if (OptionsForm.isWrongPath(installPath, Catalog)) {
                 // cancelled
                 EnableButtons();
                 return;

Source/Menu/Options.cs

@@ -728,14 +728,8 @@ private void textBoxContentName_TextChanged(object sender, EventArgs e)
             var current = bindingSourceContent.Current as ContentFolder;
             if (current != null && current.Name != textBoxContentName.Text)
             {
-                if (current.Path.ToLower().Contains(Application.StartupPath.ToLower()))
+                if (isWrongPath(current.Path, catalog))
                 {
-                    // Block added because a succesful Update operation will empty the Open Rails folder and lose any content stored within it.
-                    MessageBox.Show(catalog.GetString
-                        ($"Cannot use content from any folder which lies inside the Open Rails folder {Application.StartupPath}\n\n")
-                        , "Invalid content location"
-                        , MessageBoxButtons.OK
-                        , MessageBoxIcon.Error);
                     DeleteContent();
                     return;
                 }
@@ -792,6 +786,22 @@ private void checkPerformanceTuner_Click(object sender, EventArgs e)
             labelPerformanceTunerTarget.Enabled = checkPerformanceTuner.Checked;
         }
 
+        public static bool isWrongPath(string path, GettextResourceManager catalog)
+        {
+            if (path.ToLower().Contains(Application.StartupPath.ToLower()))
+            {
+                // check added because a succesful Update operation will empty the Open Rails folder and lose any content stored within it.
+                MessageBox.Show(catalog.GetString
+                    ($"Cannot use content from any folder which lies inside the Open Rails program folder {Application.StartupPath}\n\n")
+                    , "Invalid content location"
+                    , MessageBoxButtons.OK
+                    , MessageBoxIcon.Error);
+                return true;
+            }
+
+            return false;
+        }
+
         #region Help for Options
         // The icons all share the same code which assumes they are named according to a simple scheme as follows:
         //   1. To add a new Help Icon, copy an existing one and paste it onto the tab.