Merge pull request #66 from Csantucci/thread-safe-particleemitter

Csantucci · web-flow · commit 508714db4bf0 · 2019-06-01T16:14:19.000+02:00
Solve ParticleEmitter.cs thread safety issue.
diff --git a/Source/RunActivity/Viewer3D/ParticleEmitter.cs b/Source/RunActivity/Viewer3D/ParticleEmitter.cs
@@ -436,7 +436,9 @@ public override void Draw(GraphicsDevice graphicsDevice)
                 if (FirstActiveParticle < FirstFreeParticle)
                 {
                     var numParticles = FirstFreeParticle - FirstActiveParticle;
-                    graphicsDevice.DrawIndexedPrimitives(PrimitiveType.TriangleList, 0, FirstActiveParticle * VerticiesPerParticle, numParticles * VerticiesPerParticle, FirstActiveParticle * IndiciesPerParticle, numParticles * PrimitivesPerParticle);
+                    // thread safe clause
+                    if (numParticles > 0)
+                        graphicsDevice.DrawIndexedPrimitives(PrimitiveType.TriangleList, 0, FirstActiveParticle * VerticiesPerParticle, numParticles * VerticiesPerParticle, FirstActiveParticle * IndiciesPerParticle, numParticles * PrimitivesPerParticle);
                 }
                 else
                 {

Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,9 @@ public override void Draw(GraphicsDevice graphicsDevice)`
`436`	`436`	`if (FirstActiveParticle < FirstFreeParticle)`
`437`	`437`	`{`
`438`	`438`	`var numParticles = FirstFreeParticle - FirstActiveParticle;`
`439`		`- graphicsDevice.DrawIndexedPrimitives(PrimitiveType.TriangleList, 0, FirstActiveParticle * VerticiesPerParticle, numParticles * VerticiesPerParticle, FirstActiveParticle * IndiciesPerParticle, numParticles * PrimitivesPerParticle);`
	`439`	`+ // thread safe clause`
	`440`	`+ if (numParticles > 0)`
	`441`	`+ graphicsDevice.DrawIndexedPrimitives(PrimitiveType.TriangleList, 0, FirstActiveParticle * VerticiesPerParticle, numParticles * VerticiesPerParticle, FirstActiveParticle * IndiciesPerParticle, numParticles * PrimitivesPerParticle);`
`440`	`442`	`}`
`441`	`443`	`else`
`442`	`444`	`{`