-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Describe the bug
Currently, get_obs_var_for_integrated and get_obs_for_integrated in utils/helper_functions.py do not handle well the 'perfect integration' control method. When fetching annotation for the 'perfect integration case, the validation annotations perfectly match the integrated annotations. However, the batch variable remains the same between integrated and validation, potentially raising issues when going through metrics component.
(e.g. fitting a linear model for metrics/average_batch_r2 is not possible as there will only be 1 possible value for the batch variable)
Expected behavior
The helper functions should change the batch number when method == 'perfect integration' so that the batch annotation is swapped (e.g. if a row is annotated as 'batch' == 1, it should be swapped to 'batch' == 2).
Note: ideally the swapping should work in the case of 3+ batches too.
Additional context
PR #36 now contains an exception for 'perfect_integration' where it changes the batch number (hardcoded). The exception must be removed once this issue is solved