-
Notifications
You must be signed in to change notification settings - Fork 231
8337102: JITTester: Fix breaks in static initialization blocks #3941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8337102: JITTester: Fix breaks in static initialization blocks #3941
Conversation
|
Hi @kirill-shirokov, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kirill-shirokov" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
/covered |
|
❗ This change is not yet ready to be integrated. |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
This backport pull request has now been updated with issue from the original commit. |
|
@kirill-shirokov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
|
|
@kirill-shirokov This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@kirill-shirokov This pull request is now open |
The backport verified on MacOS/Linux/Windows by manually running JITTester.
Verification involved modifying JITTester code to terminate with non-zero exit code when encountering specific compilation error (a break statement in a static initializer) in the generated code and enabling static initializer generation in configuration file in non-fixed version.
Without the fix typically the error reproduces during the first generation round.
With the fix, there is no error for 10s of rounds.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3941/head:pull/3941$ git checkout pull/3941Update a local copy of the PR:
$ git checkout pull/3941$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3941/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3941View PR using the GUI difftool:
$ git pr show -t 3941Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3941.diff
Using Webrev
Link to Webrev Comment