Skip to content

Commit f299e7c

Browse files
committed
Fix testStableSemconv tests for hibernate-procedure-call and r2dbc
1 parent ceee40f commit f299e7c

File tree

2 files changed

+13
-3
lines changed
  • instrumentation
    • hibernate/hibernate-procedure-call-4.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_3
    • r2dbc-1.0/library/src/test/java/io/opentelemetry/instrumentation/r2dbc/v1_0

2 files changed

+13
-3
lines changed

instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_3/ProcedureCallTest.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
import static io.opentelemetry.javaagent.instrumentation.hibernate.ExperimentalTestHelper.experimental;
1414
import static io.opentelemetry.javaagent.instrumentation.hibernate.ExperimentalTestHelper.experimentalSatisfies;
1515
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
16+
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.satisfies;
17+
import static io.opentelemetry.semconv.DbAttributes.DB_QUERY_SUMMARY;
1618
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_CONNECTION_STRING;
1719
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_NAME;
1820
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_OPERATION;
@@ -118,7 +120,8 @@ void testProcedureCall() {
118120
HIBERNATE_SESSION_ID,
119121
val -> assertThat(val).isInstanceOf(String.class))),
120122
span ->
121-
span.hasName("CALL test.TEST_PROC")
123+
span.hasName(
124+
emitStableDatabaseSemconv() ? "CALL TEST_PROC" : "CALL test.TEST_PROC")
122125
.hasKind(CLIENT)
123126
.hasParent(trace.getSpan(1))
124127
.hasAttributesSatisfyingExactly(
@@ -129,7 +132,13 @@ void testProcedureCall() {
129132
equalTo(
130133
DB_CONNECTION_STRING,
131134
emitStableDatabaseSemconv() ? null : "hsqldb:mem:"),
132-
equalTo(maybeStable(DB_OPERATION), "CALL")),
135+
equalTo(maybeStable(DB_OPERATION), "CALL"),
136+
satisfies(
137+
DB_QUERY_SUMMARY,
138+
val ->
139+
val.satisfiesAnyOf(
140+
v -> assertThat(v).isNull(),
141+
v -> assertThat(v).isInstanceOf(String.class)))),
133142
span ->
134143
span.hasName("Transaction.commit")
135144
.hasKind(INTERNAL)

instrumentation/r2dbc-1.0/library/src/test/java/io/opentelemetry/instrumentation/r2dbc/v1_0/SqlCommenterTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package io.opentelemetry.instrumentation.r2dbc.v1_0;
77

8+
import static io.opentelemetry.instrumentation.api.internal.SemconvStability.emitStableDatabaseSemconv;
89
import static io.r2dbc.spi.ConnectionFactoryOptions.CONNECT_TIMEOUT;
910
import static io.r2dbc.spi.ConnectionFactoryOptions.DATABASE;
1011
import static io.r2dbc.spi.ConnectionFactoryOptions.DRIVER;
@@ -139,7 +140,7 @@ public void beforeQuery(QueryExecutionInfo execInfo) {
139140
trace.hasSpansSatisfyingExactly(
140141
span -> span.hasName("parent").hasKind(SpanKind.INTERNAL),
141142
span ->
142-
span.hasName("SELECT " + DB)
143+
span.hasName(emitStableDatabaseSemconv() ? "SELECT" : "SELECT " + DB)
143144
.hasKind(SpanKind.CLIENT)
144145
.hasParent(trace.getSpan(0)),
145146
span ->

0 commit comments

Comments
 (0)