pr feedback on add/diff for aints

hppritcha · hppritcha · commit 5ac0810b5550 · 2025-12-01T08:52:52.000-07:00
Signed-off-by: Howard Pritchard &lt;howardp@lanl.gov&gt;
diff --git a/ompi/mpi/c/aint_add_abi.c b/ompi/mpi/c/aint_add_abi.c
@@ -35,6 +35,6 @@
 
 MPI_Aint MPI_Aint_add(MPI_Aint addr1, MPI_Aint addr2)
 {
-    return (addr1 + addr2);
+    return (MPI_Aint)((char *)(addr1) + (addr2));
 }
 
diff --git a/ompi/mpi/c/aint_diff_abi.c b/ompi/mpi/c/aint_diff_abi.c
@@ -36,6 +36,6 @@
 
 MPI_Aint MPI_Aint_diff(MPI_Aint addr1, MPI_Aint addr2)
 {
-    return (addr1 - addr2);
+    return (MPI_Aint)((char *)(addr1) - (char *)(addr2));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,6 @@`
`35`	`35`
`36`	`36`	`MPI_Aint MPI_Aint_add(MPI_Aint addr1, MPI_Aint addr2)`
`37`	`37`	`{`
`38`		`- return (addr1 + addr2);`
	`38`	`+ return (MPI_Aint)((char *)(addr1) + (addr2));`
`39`	`39`	`}`
`40`	`40`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,6 @@`
`36`	`36`
`37`	`37`	`MPI_Aint MPI_Aint_diff(MPI_Aint addr1, MPI_Aint addr2)`
`38`	`38`	`{`
`39`		`- return (addr1 - addr2);`
	`39`	`+ return (MPI_Aint)((char )(addr1) - (char )(addr2));`
`40`	`40`	`}`
`41`	`41`