Skip to content

Fix exercise 1-18 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duphyf wants to merge 2 commits into from
Closed

Fix exercise 1-18 #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5f2e2a
Refactor remove_trailing_blanks: fix logic and return updated length
duphyf Nov 30, 2025
ff98d26
Add logic to delete entirely blank lines
duphyf Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions chapter_1/exercise_1_18/trailing_blanks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#define MAXLINE 1000

int get_line(char line[], int max_line_len);
void remove_trailing_blanks(char line[], int length);
int remove_trailing_blanks(char line[], int length);

int main(void)
{
Expand All @@ -12,8 +12,12 @@ int main(void)

while ((len = get_line(line, MAXLINE)) > 0)
{
remove_trailing_blanks(line, len);
printf("%s", line);
len = remove_trailing_blanks(line, len);

if (len > 1 || line[0] != '\n')
{
printf("%s", line);
}
}

return 0;
Expand All @@ -39,13 +43,30 @@ int get_line(char line[], int max_line_len)
return i;
}

void remove_trailing_blanks(char line[], int length)
#define HAS_NEWLINE 1
#define NO_NEWLINE 0

int remove_trailing_blanks(char line[], int length)
{
int i;
int i, has_newline;

has_newline = NO_NEWLINE;

for (i = length - 1; i >= 0 && (line[i] == '\n' || line[i] == ' ' || line[i] == '\t'); --i)
{
if (line[i] == '\n')
{
has_newline = HAS_NEWLINE;
}
}

for (i = length - 2; line[i] == ' ' || line[i] == '\t'; --i)
;
if (has_newline == HAS_NEWLINE)
{
line[i + 1] = '\n';
line[i + 2] = '\0';
return i + 2;
}

line[i + 1] = '\n';
line[i + 2] = '\0';
line[i + 1] = '\0';
return i + 1;
}